Closed Bug 1197873 Opened 9 years ago Closed 9 years ago

[Music][NGA] Move '#endpoint' services to parent window

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

Attachments

(2 files)

[gaia] justindarc:bug1197873 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
squib
: review+
hub
: review+
Details | Review
[gaia] justindarc:bug1197873-v2 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review 
In order to prevent making multiple hops between iframes from views to the services, the services defined in the #endpoint iframe should be moved to the parent window (index.html).
Assignee: nobody → jdarcangelo
Make sure you update the tests - there is one place where we access endpoint, at least. Feel free to ping me.
Attachment #8651965 - Flags: review?(squibblyflabbetydoo)
Attachment #8651965 - Flags: review?(squibblyflabbetydoo) → review+
Comment on attachment 8651965 [details] [review]
[gaia] justindarc:bug1197873 > mozilla-b2g:master

Review the test changes. Looks got to me for that part.
Attachment #8651965 - Flags: review+
s/got/good/
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/d95dd48d64451062bdffaf1c5d1c619e4c0b0acc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Backed out along with bug 1196425.

https://github.com/mozilla-b2g/gaia/commit/0f36e6a30d0acff35b0ee8cfa859cf73de5a57a1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1196414
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/1591a8851257bcab2b31afa76daa8b9a9c54c9ae
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: