Remove MatchstickApp.jsm from the build

RESOLVED FIXED in Firefox 43

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rnewman, Assigned: anirudh24seven, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 43
All
Android
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

(Whiteboard: [good-first-bug][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Matchstick isn't going to ship, right? If we don't have any other consumers for this code, we should save the kilobytes.
Mentor: mark.finkle@gmail.com
Whiteboard: [good-first-bug][lang=js]
(Assignee)

Comment 1

2 years ago
Created attachment 8659283 [details] [diff] [review]
Remove MatchstickApp.jsm from the build
(Reporter)

Updated

2 years ago
Attachment #8659283 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

2 years ago
I have removed all references to Matchstick. This should be enough, right?
Flags: needinfo?(mark.finkle)
Comment on attachment 8659283 [details] [diff] [review]
Remove MatchstickApp.jsm from the build

Yes. Looks good.
Flags: needinfo?(mark.finkle)
Attachment #8659283 - Flags: review?(mark.finkle) → review+
Assignee: nobody → anirudh24seven
(Reporter)

Updated

2 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 4

2 years ago
Anirudh: could you push this to Try before setting checkin-needed?

https://wiki.mozilla.org/ReleaseEngineering/TryServer
(Assignee)

Comment 5

2 years ago
Richard: Sure. Will do so.

I would require someone to vouch for my Level 1 Commit Access though. 
https://bugzilla.mozilla.org/show_bug.cgi?id=1204188
Flags: needinfo?(rnewman)
(Reporter)

Comment 6

2 years ago
Vouched.
Flags: needinfo?(rnewman)
(Assignee)

Comment 7

2 years ago
I pushed it to Try and it completed successfully.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29fe2bcd7ff6
Flags: needinfo?(rnewman)
Keywords: checkin-needed

Comment 8

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/d9824a8871c8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d9824a8871c8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
(Reporter)

Updated

2 years ago
Flags: needinfo?(rnewman)
You need to log in before you can comment on or make changes to this bug.