Closed Bug 1197874 Opened 4 years ago Closed 4 years ago

Remove MatchstickApp.jsm from the build

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: rnewman, Assigned: anirudh24seven, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good-first-bug][lang=js])

Attachments

(1 file)

Matchstick isn't going to ship, right? If we don't have any other consumers for this code, we should save the kilobytes.
Mentor: mark.finkle
Whiteboard: [good-first-bug][lang=js]
Attachment #8659283 - Flags: review?(mark.finkle)
I have removed all references to Matchstick. This should be enough, right?
Flags: needinfo?(mark.finkle)
Comment on attachment 8659283 [details] [diff] [review]
Remove MatchstickApp.jsm from the build

Yes. Looks good.
Flags: needinfo?(mark.finkle)
Attachment #8659283 - Flags: review?(mark.finkle) → review+
Assignee: nobody → anirudh24seven
Status: NEW → ASSIGNED
Anirudh: could you push this to Try before setting checkin-needed?

https://wiki.mozilla.org/ReleaseEngineering/TryServer
Richard: Sure. Will do so.

I would require someone to vouch for my Level 1 Commit Access though. 
https://bugzilla.mozilla.org/show_bug.cgi?id=1204188
Flags: needinfo?(rnewman)
Vouched.
Flags: needinfo?(rnewman)
I pushed it to Try and it completed successfully.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29fe2bcd7ff6
Flags: needinfo?(rnewman)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d9824a8871c8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Flags: needinfo?(rnewman)
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 43 → mozilla43
You need to log in before you can comment on or make changes to this bug.