1197875 - Tree Style tab fails to display new tabs in Fx42+

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Edwin Wong [:edwong]]

Attachment: Screen Shot 2015-08-24 at 9.22.36 AM.png

I can't use Fx42 or greater as any new tabs are not displayed to the user.  This bug does not occur with Fx41 or earlier. 

STR:
1. install Tree Style Tab add-on
2. create a new tab any way you want (keyboard, menu)

actual: the tab is hidden, you can see it's offset a bit.

Comment 1

[Edwin Wong [:edwong]]

Please can we fix this before it hits release channel!

Comment 2

[Edwin Wong [:edwong]]

:dolske do you know who i can talk to about this bug

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=43319cd779a9bc38b421b921f2f30df2de327e62&tochange=3a1e94ccb9df8893ba423f28bcd03224c7b77334

Fallout from bug 909154?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Seems plausible, since the tree style tab version on AMO has, in modules/lib/animationManager.js:

  aWindow.mozRequestAnimationFrame(function() {
    self.processAnimationFrame(aWindow);
  });

in two different places.  They need to update the addon to use requestAnimation instead; since they're not using the argument to the callback function at all, this should be a trivial update... except they need to stop using mozAnimationStartTime as well.

We did discuss this in bug 909154 and the conclusion was that the small number of affected addons could be updated easily.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

This was reported and fixed a while ago: https://github.com/piroor/treestyletab/issues/915. As far as I know, the updated version hasn't been distributed yet, and it's not on AMO.

Comment 6

[Edwin Wong [:edwong]]

I've built the xpi from source and posted here for my personal use: https://people.mozilla.org/~ewong2/treesytletab/

closing as invalid