Playback test sometimes times out too soon when YouTube video has ad at the beginning or mid-way

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: maja_zf, Assigned: maja_zf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In short, the problem is that |current_time| and |duration| reported by YouTube refer to whatever stream is playing right now, and that stream might be an ad, not the main video.
Created attachment 8651929 [details] [review]
GitHub pull request
Attachment #8651929 - Flags: review?
Attachment #8651929 - Flags: review? → review?(spolk)

Comment 2

4 years ago
I have some questions put into the pull request. Please answer those. I don't anticipate any code changes coming out of them, so leaving the review flag along for now.
Flags: needinfo?(mjzffr)
Done.
Flags: needinfo?(mjzffr)

Updated

4 years ago
Attachment #8651929 - Flags: review?(spolk) → review+

Comment 4

4 years ago
Looks good. Please merge. Thanks.
https://github.com/mjzffr/firefox-media-tests/commit/de8f41546d7fbd5191349b1290f1930fb2d7a297

Also added back the video that caused us to notice the early-timeout problem:
https://github.com/mjzffr/firefox-media-tests/commit/b738fa6a1f539faef0509a5a059aa01c25865b64

Deployed to pf-jenkins branch.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

a year ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.