From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.7+) Gecko/20020111 BuildID: 2002011103 Sometime around Jan. 3, the Last Visited bookmark field stopped working. Reproducible: Always Steps to Reproduce: 1. Open Manage Bookmarks window 2. Turn on "Last Visited" display Actual Results: Notice that all bookmarks have a blank Last Visited field Expected Results: Last Visited field shows the time and date that the page was last visited. Works with 0.9.7 Works with 2002010303 Doesn't work with 2002010403 Doesn't work with 2002011103
Note that the Last Visited time is remembered correctly with current builds. This seems to be only a display problem. I.E. if you visit a bookmark with 2002011103, then run 0.9.7, the Last Visited time does correctly reflect the visit just made in 2002011103.
16 years ago
This worked fine in previous releases. It appears that the backend is still functioning so this shouldn't be too difficult to explore and fix. If we don't fix this then the column should be removed from the Bookmarks Manager for the next major releases.
nsbeta1- per Nav triage team, ->1.2
Actually, the "last visited" field is displayed in the "added" column.
Same thing with Mac OS 9.1 Build 2002061103
confirming comment #4 "last visited" content appears in "added" field, should be very easy to fix now
Created attachment 98615 [details] [diff] [review] Patch to fix the bug Added a patch to fix the bug and to display the last modified date correctly as well.
just for the notes: this bug needs a new traget ... the bug lies not within the viewer the data is saved to the wrong field in bookmarks.html
> this bug needs a new traget ... Agreed. Since this is a trivial fix, perhaps it could be mozilla1.2beta? Well, I guess it really depends on when will Ben have time for this. > the bug lies not within the viewer > the data is saved to the wrong field in bookmarks.html No, the problem *is* with the viewer: 1. The order of the columns in the column definition of the bookmark tree is not the same as the order of cells in the body of the tree 2. The label of the Last Modified Date has changed from NC-rdf to WEB-rdf, but bookmarks.xml still uses NC-rdf These two errors are corrected in the patch that is attached to this bug.
Created attachment 102665 [details] [diff] [review] Updated patch to fix the bug Updated patch for the latest version (1.47) in the trunk
try asking the review of a specific person, I think jag (firstname.lastname@example.org) would be good for fixes in this area.
*** Bug 193920 has been marked as a duplicate of this bug. ***
*** Bug 146534 has been marked as a duplicate of this bug. ***
*** Bug 197609 has been marked as a duplicate of this bug. ***
*** This bug has been marked as a duplicate of 124819 ***
sorry, I haven't noticed thar there is a patch attached. Can I take it and check into the bookmarks branch ?
Created attachment 117535 [details] [diff] [review] Patch diffed against the latest tree Althogh the patch is trivial, I still do not have r= or sr= for it. If you can check it in anyway, please, do it.
sorry for not letting you know, this is already fixed on the branch we are working on, so you don't have to request a review for this.
reopening, since this bug has a patch
Using the 2003-03-25-03 Mach0 and 2003-03-25-04 Win32 trunk builds, The last visited field is now providing the correct time on when that bookmark was previously loaded.
I probably caused a confusion here. This is fixed on the trunk by big bookmarks landing on Monday.
OK, this looks fine now. Marking verified.
Comment on attachment 117535 [details] [diff] [review] Patch diffed against the latest tree ooh, that's easy. sr=alecf
15 years ago