1197960 - Unable to james upgrade master

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

If I run `james stage master` it automatically figures out what git SHA that is and sends that to chief. However our Chief can't deal with that. Here's a sample error::

I am trying to load /data/genericrhel6-stage/src/air.allizom.org/air/bin/update/update.py
[2015-08-24 12:48:27] Running pre_update
[2015-08-24 12:48:27] Running update_code
[2015-08-24 12:48:27] [localhost] running: cd /data/genericrhel6-stage/src/air.allizom.org/air && git checkout a442e1fe0c4f8c7bc9bef603cdb9b05b58fe6a9d
[2015-08-24 12:48:27] [localhost] failed: cd /data/genericrhel6-stage/src/air.allizom.org/air && git checkout a442e1fe0c4f8c7bc9bef603cdb9b05b58fe6a9d (0.020s)
[localhost] err: fatal: reference is not a tree: a442e1fe0c4f8c7bc9bef603cdb9b05b58fe6a9d


At the time of writing, a442e1fe0c4f8c7bc9bef603cdb9b05b58fe6a9d is a perfectly good commit. It's the tip of the master branch on github.com/mozilla/airmozilla

Comment 1

[Peter Bengtsson [:peterbe]]

PR https://github.com/mozilla/airmozilla/pull/457

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/1cbdf4462920ab3ab03f48dda336652078e7c400
Change update.py to match chief-james's expecations.

chief-james expects update.py to unconditionally check out the ref that
is passed. Previously, update_code would treat the parameter passed to
it as a branch name to check out and update. This changes update_code to
treat the parameter passed as a ref to get from the server, matching
chief-james's expectations.

fixes bug 1197960