Add ability to retrigger all talos jobs X number of times

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mchang, Assigned: vaibhav1994)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
When using perfherder, I usually have to retrigger the talos jobs to get a good comparison. It'd be nice to just push once to try with talos jobs and say "run each talos job 5 times". Then when the two try pushes are done, it's a lot easier to compare. Right now, I have to wait for try to finish, then go through each talos job for each platform, and retrigger X times.
simple way is to add: '--rebuild 5' to the try syntax.  We didn't get agreement from release engineering to do this by default, we have other options as well.  If --rebuild doesn't work for you or it is easy to forget, do let us know!
(Reporter)

Comment 2

3 years ago
Can we get a little button in try chooser as an option then?
Flags: needinfo?(jmaher)
we have the --rebuild option as a text box in try chooser, I would be happy to default it to something if you are choosing talos jobs.
Flags: needinfo?(jmaher)
(Reporter)

Comment 4

3 years ago
(In reply to Joel Maher (:jmaher) from comment #3)
> we have the --rebuild option as a text box in try chooser, I would be happy
> to default it to something if you are choosing talos jobs.

Hmm, but the rebuild option runs all tests 5 times right? Can I do a try push that does all the unit tests once and only the talos jobs 5 times?
it is possible, but not via the try page- we could set up pulse actions to do this by default- I think it is the right thing to do- also we can make the run all talos jobs work for all folks on try.

adding :vaibhav1994 and :adusca as they are the masterminds of some of this stuff.
(Assignee)

Comment 6

3 years ago
We decided in bug 1194711 that we do not want to make triggering talos jobs 6 times by default (since we are constrained on talos machines). We have a --rebuild option in try syntax but that triggers all the jobs. So, we can have --rebuild-talos option in try-syntax that will trigger only talos jobs. This can be incorporated in trigger-bot since trigger-bot handles --rebuild option. Mason, Joel does that sound good to you?
yeah, I think --rebuild should work the same on everything and if there is a --rebuild-talos then that should be used for what talos has.
(Reporter)

Comment 8

3 years ago
(In reply to Vaibhav (:vaibhav1994) from comment #6)
> We decided in bug 1194711 that we do not want to make triggering talos jobs
> 6 times by default (since we are constrained on talos machines). We have a
> --rebuild option in try syntax but that triggers all the jobs. So, we can
> have --rebuild-talos option in try-syntax that will trigger only talos jobs.
> This can be incorporated in trigger-bot since trigger-bot handles --rebuild
> option. Mason, Joel does that sound good to you?

Yeah, a --rebuild-talos option would work!
(Assignee)

Comment 9

3 years ago
Created attachment 8652422 [details]
MozReview Request: Bug 1197978 - Adding --rebuild-talos option in trychooser. r=jmaher

Bug 1197978 - Adding --rebuild-talos option in trychooser. r=jmaher
Attachment #8652422 - Flags: review?(jmaher)
(Assignee)

Comment 10

3 years ago
This is the front-end, will land this once the required functionality is in trigger-bot.
Comment on attachment 8652422 [details]
MozReview Request: Bug 1197978 - Adding --rebuild-talos option in trychooser. r=jmaher

https://reviewboard.mozilla.org/r/17161/#review15259

::: trychooser/index.html:487
(Diff revision 1)
> +            <p>Retrigger all talos jobs (up to 20 times):</p>

we are sort of overloading something in here, in this case I would like to see us specify something other than what is here.  Visually this looks cluttered and confusing (not that the whole page isn't).

::: trychooser/trychooser.js:181
(Diff revision 1)
> +        args.push('--rebuild-talos ' + rebuild_talos);

what accepts --rebuild-talos?
Attachment #8652422 - Flags: review?(jmaher)
(Assignee)

Comment 12

3 years ago
Comment on attachment 8652422 [details]
MozReview Request: Bug 1197978 - Adding --rebuild-talos option in trychooser. r=jmaher

Bug 1197978 - Adding --rebuild-talos option in trychooser. r=jmaher
Attachment #8652422 - Flags: review?(jmaher)
Attachment #8652422 - Flags: review?(jmaher) → review+
Comment on attachment 8652422 [details]
MozReview Request: Bug 1197978 - Adding --rebuild-talos option in trychooser. r=jmaher

https://reviewboard.mozilla.org/r/17161/#review15267

Ship It!
(Assignee)

Comment 14

3 years ago
Created attachment 8652686 [details] [review]
github-pr

Attaching github-pr.
Attachment #8652686 - Flags: review?(cmanchester)
Comment on attachment 8652686 [details] [review]
github-pr

This is looking good. I'll find some time to deploy over the weekend.
Attachment #8652686 - Flags: review?(cmanchester) → review+
(Assignee)

Comment 16

3 years ago
:chmanchester said that he has deployed the backend for --rebuild-talos in triggerbot. We can now land the front-end for the trychooser (mozreview patch). This patch does not require a try run since it is only a small change in trychooser page.
Keywords: checkin-needed
Assignee: nobody → vaibhavmagarwal
Keywords: checkin-needed
Status: NEW → ASSIGNED
(Assignee)

Comment 18

3 years ago
:Callek, can you update the trychooser page ( http://trychooser.pub.build.mozilla.org/ ) to have --rebuild-talos option showing to users?
Flags: needinfo?(bugspam.Callek)
[root@relengwebadm.private.scl3 trychooser]# ./update tip
pulling from http://hg.mozilla.org/build/tools
searching for changes
adding changesets
adding manifests
adding file changes
added 59 changesets with 113 changes to 35 files
(run 'hg update' to get a working copy)
35 files updated, 0 files merged, 0 files removed, 0 files unresolved
Deploying code...
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(bugspam.Callek)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.