1198005 - Investigate and possibly remove rules for border-radius on toolkit <tab>

Status: RESOLVED DUPLICATE of bug 1354199

(Toolkit :: Themes, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

At
- https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/tabbox.css?offset=1100#55
tab:-moz-locale-dir(rtl) {
  border-bottom-left-radius: 1px;
  border-bottom-right-radius: 0px;
}

- https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/tabbox.css?offset=100#55
tab[visuallyselected="true"] {
  z-index: 1;
  margin-top: 0;
  margin-bottom: -2px;
  border-bottom-left-radius: 3px;
  border-bottom-right-radius: 3px;
  padding-top: 4px;
  padding-bottom: 6px;
}

there are rules for bottom border-radius which are likely overridden in other places and unknowingly present in other places. We can probably remove these rules, but someone should look at the places that these apply and see if they need to stay. The Windows rules have been present since hg@1, I didn't investigate the Linux ones.

Comment 1

[Tim Nguyen :ntim]

There are also some oddball rules on OSX : https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/tabbox.css?offset=700#119

tabbox.tabs-bottom > tabs > tab[visuallyselected=true],
tabs.tabs-bottom > tab[visuallyselected=true] {
  color: #000;
  text-shadow: none;
  border: solid #888;
  border-width: 0 2px 2px;
  border-radius: 2px;
  -moz-border-left-colors: rgba(0, 0, 0, 0.08) #888;
  -moz-border-right-colors: rgba(0, 0, 0, 0.08) #888;
  -moz-border-bottom-colors: rgba(0, 0, 0, 0.08) #888;
  -moz-margin-end: -1px;
  margin-top: -2px;
  margin-bottom: 1px;
  padding: 0;
}

Comment 2

[Stefan [:stefanh]]

I'd suggest leaving the OSX rules as-is, since they're for bottom tabs (I don't think they're overridden).

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Stefan [:stefanh] (away until August 25) from comment #2)
> I'd suggest leaving the OSX rules as-is, since they're for bottom tabs (I
> don't think they're overridden).

When do we show bottom tabs on OSX?

Comment 4

[Stefan [:stefanh]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> (In reply to Stefan [:stefanh] (away until August 25) from comment #2)
> > I'd suggest leaving the OSX rules as-is, since they're for bottom tabs (I
> > don't think they're overridden).
> 
> When do we show bottom tabs on OSX?

I guess you mean when we show bottom tabs in general (since they're part of the tabbox widget). I know that chatzilla and seamonkey composer uses bottom tabs. On OSX (dunno about win/linux), these tabs looks different than the regular ("top") tabs.