Closed Bug 1198050 Opened 9 years ago Closed 3 years ago

Change alpha of disabled text in menu to @color/disabled_grey

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: mcomella, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=java][bad first bug]) 

(In reply to Anthony Lam (:antlam) from bug 1148550 comment #6)
> Is the font color for disabled text (like Find in Page and Page) here
> consistent with our disabled grey?

I don't think so – MenuItemDefault changes the alpha in setEnabled [1].

Note that the menu code is complicated so this can be harder than it seems.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/MenuItemDefault.java?rev=e925a610e68d#113
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.