Closed
Bug 1198100
Opened 9 years ago
Closed 9 years ago
remove mNotificationMainThreadRunnable
Categories
(Core :: Audio/Video: MediaStreamGraph, defect)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
Details
All callers of AddMainThreadListener make the call before the stream is even in the graph, well before mFinishedNotificationSent is set. If AddMainThreadListener() were called multiple times after mFinishedNotificationSent is set then we'd get some extra NotifyRunnables but NotifyMainThreadListeners() clears mMainThreadListeners anyway so we still get only one notification per listener. mNotificationMainThreadRunnable is an unnecessary optimization, so better not to add storage to every MediaStream. patch reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1196632#c9
Assignee | ||
Updated•9 years ago
|
Flags: in-testsuite-
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b56b5816ec38
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•