1198134 - Sort Range Voting Result View

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Michael Kohler [:mkohler]]

The result view should be sorted by points for range votings. Like this we can directly see who had the most points.

Example: https://reps.mozilla.org/v/rep-of-the-month-for-august/

Comment 1

[Tasos Katsoulas [:tasos]]

Hi Michael,

I am leaning towards characterizing this bug as wontfix. What you are describing, was exactly implemented until 3 months ago. What changed is that when we introduced the ability to comment on a voting and had the names sorted by votes and not alphabetically, basically we allowed everyone to have a rough idea how the poll was evolving. Eg if Michael and Tasos were in a range poll and Michael was first that basically meant that Michael had more votes. In order to have the fairest possible voting tool we decided to sort everything alphabetically.

Thoughts?

Comment 2

[Michael Kohler [:mkohler]]

Good input, I can understand that. Is there a possibility to only sort it when the voting is finished?

Comment 3

[Tasos Katsoulas [:tasos]]

Yes, we can do this but it's going to take a while. The main problem here is that we need both to restructure and create templates and also redesign some of the backend because the 'vote' and 'view a voting' functionality are handled by the same view (function) and the same template.

Comment 4

[Tasos Katsoulas [:tasos]]

After Jinja v2.6 a filter is enough for the requested functionality.
PR opened here:
https://github.com/mozilla/remo/pull/1219

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/86f4947f663cc9198ac3c4349d5286ee870a0ff5
[fix bug 1198134] Sort the results in range polls.

https://github.com/mozilla/remo/commit/92881bcf9346517f5c811692037c0a27d8f07e50
Merge pull request #1219 from akatsoulas/1198134-sort-range-poll-results

[fix bug 1198134] Sort the results in range polls.

Comment 6

[John Giannelos [:nemo-yiannis]]

Verified on stage:

* The results of range polls are in descending order