Closed Bug 1198155 Opened 9 years ago Closed 9 years ago

Intermittent browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js | Test timed out | Found a devtools:webconsole after previous test timed out

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 unaffected, firefox42 unaffected, firefox43 fixed, firefox-esr38 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox41 --- unaffected
firefox42 --- unaffected
firefox43 --- fixed
firefox-esr38 --- unaffected

People

(Reporter: nigelb, Assigned: sjakthol)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 2 obsolete files)

bug-1198155-message-matching.patch
1.74 KB, patch
past
: review+
sjakthol
: checkin+
Details | Diff | Splinter Review
bug-1198155-try-2-message-filtering.patch
1.61 KB, patch
sjakthol
: review+
Details | Diff | Splinter Review 
      No description provided.
Summary: Intermittent browser/devtools/webconsole/test/browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js | Test timed out - expected PASS | Found a devtools:webconsole after previous test timed out - expected PASS → Intermittent browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js | Test timed out | Found a devtools:webconsole after previous test timed out
This is extremely frequent. Panos, can you please look into this or suggest someone who can? Thanks!
Flags: needinfo?(past)
The test waits for a message it logs that should contain the word 'Object'. That is quite common and the failure is caused by an unrelated message containing that word.

This patch adds an unique property to the logged object so that the test will always match the correct message.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b916e6b2a93
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Flags: needinfo?(past)
Attachment #8654102 - Flags: review?(past)
Comment on attachment 8654102 [details] [diff] [review]
bug-1198155-message-matching.patch

Review of attachment 8654102 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Sami!
Attachment #8654102 - Flags: review?(past) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0a2a2b0f06d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
This is definitely still happening but not so often. This time it seems that those health reporter errors with long stack traces are pushing our message out of view. When the test tries to simulate a click on the variables-view link it fails as the link has scrolled out of view.

The easiest fix is to call .click() on the link directly as that does not care if the link is scrolled out of view but serves the same purpose for the test.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
status-firefox43: fixed → ---
That idea did not work out that well. Apparently calling .click() sets the number of clicks to 0 on the event and the console will only allow the event to go trough the number of clicks is 1.

The next idea I'm testing is to filter out every message expect the one the test prints.
Here's the patch that filters unexpected messages from the console.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec847df58394
Attachment #8654606 - Flags: review?(past)
Oops, here's the correct patch file.
Attachment #8654606 - Attachment is obsolete: true
Attachment #8654606 - Flags: review?(past)
Attachment #8654607 - Flags: review?(past)
Attachment #8654102 - Flags: checkin+
Comment on attachment 8654607 [details] [diff] [review]
bug-1198155-try-2-message-filtering.patch

Review of attachment 8654607 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webconsole/test/browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js
@@ +33,5 @@
>    }
>  
>    let deferred = promise.defer();
> +
> +  // Filter out other messages to ensure our stays visible.

Typo: "ours"
Attachment #8654607 - Flags: review?(past) → review+
Fixed the typo.
Attachment #8654607 - Attachment is obsolete: true
Attachment #8654614 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8c2d5ed2d654
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: