1198206 - The first letter is not auto-capitalized in the edit mode in the contact's 'Street name' field by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Lev]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150823004007

Steps to reproduce:

In New Contact screen, add a street name
Start to enter letters


Actual results:

'Street name' first symbol is not capitalized


Expected results:

'Street name' first symbol is capitalized

Comment 1

[Johan Lorenzo [:jlorenzo] - PTO - Back August 24th]

Confirmed on today's master. I'm not sure what's the expected behavior, though. I know in the US, a street is usually capitalized (like "555 Main Street"). In France, though, the first letter is usually not (like "42 avenue des Champs-Élysées", because "avenue" is a common name, and common names don't start with a capital letter, unless they are at the beginning of a sentence).

To the UX team, what should be the expected behavior?

Comment 2

[Tiffanie Shakespeare [:tif]]

Can you please give us some clarification and some examples? Screenshots are also very helpful!

Thanks for pinging the UX team!

Comment 3

[Lev]

For example, I want to type in street name 'Rodeo drive'. It has to be capitalized. But when I place the cursor to the 'Street' field and start typing, it starts from a lower case letter. It's inconvenient for the user. That's a minor issue of course.

But at the same time, in text field 'City' there's no such issue.

Comment 4

[Tiffanie Shakespeare [:tif]]

Discussed in triage today:

Yes, the first letter in the field should be capitalized - exactly the same behaviour as the city field.

Thanks for pinging the UX team!

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] ruoslepov:bug-1198206-the-first-letter-is-not-auto-capitalized > mozilla-b2g:master

Comment 6

[Alexey Yakimov]

Comment on attachment 8694661 [details] [review]
[gaia] ruoslepov:bug-1198206-the-first-letter-is-not-auto-capitalized > mozilla-b2g:master

Francisco, could you please review this simple patch or assign it to someone else. Thanks.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8694661 [details] [review]
[gaia] ruoslepov:bug-1198206-the-first-letter-is-not-auto-capitalized > mozilla-b2g:master

LGTM, thanks for the contribution!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/d379f6f96cd716467568a4d8ca2472fc5be5c577

Comment 9

[Maria Angeles Oteo (:oteo)]

Francisco, NGA branch? ;)

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

NGA branch:

4fc0812

;)

Comment 11

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0.

Actual results:  The first letter is auto-capitalized in the edit mode in the contact's 'Street name' field by default.
See attachment: verified_Flame_master.3gp
Reproduce rate: 0/10


Device: Flame KK master_512mb (Pass)
Build ID               20151204011048
Gaia Revision          23a94087e701c4bc592f2943e1007e25a9242f97
Gaia Date              2015-12-03 16:43:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/528fc18a86d3f6e6bec37190522a46853a846665
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151204.003150
Firmware Date          Fri Dec  4 00:31:59 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151204011103
Gaia Revision          23a94087e701c4bc592f2943e1007e25a9242f97
Gaia Date              2015-12-03 16:43:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/528fc18a86d3f6e6bec37190522a46853a846665
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151204.003012
Firmware Date          Fri Dec  4 00:30:20 UTC 2015
Bootloader             s1

Comment 12

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master.3gp