Closed Bug 1198228 Opened 7 years ago Closed 7 years ago

[mozprofile] use attributes on <em:Description> to get addon details, too

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: Pike, Assigned: Pike)

References

Details

Attachments

(1 file)

Language packs use em:foo attributes on <em:Description> to communicate their data.

For them to be installable in tests, we need to parse those, too, and not just child nodes.
bug 1198228, support em:foo attributes on Description elements, r=whimboo

The install.rdf in language packs uses em:id attributes etc, instead
of child elements. All fine with RDF/XML.
This adds support to addon_details to allow for those attributes in
addition to child elements.
Attachment #8652801 - Flags: review?(hskupin)
Comment on attachment 8652801 [details]
MozReview Request: bug 1198228, support em:foo attributes on Description elements, r=whimboo

https://reviewboard.mozilla.org/r/17297/#review15343

Looks fine to me. Please make sure to run the change for Marionette unit tests for all major platforms on try.
Attachment #8652801 - Flags: review?(hskupin) → review+
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Builds passed on osx, linux, win32, marking for check-in.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/379dd01ca525
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Axel, if that fix is important for you lets make sure we get a new release of mozprofile out. Just let me know.
(In reply to Henrik Skupin (:whimboo) from comment #7)
> Axel, if that fix is important for you lets make sure we get a new release
> of mozprofile out. Just let me know.

Yes, that would be helpful, thanks.
You need to log in before you can comment on or make changes to this bug.