1198228 - [mozprofile] use attributes on <em:Description> to get addon details, too

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Axel Hecht [:Pike]]

Language packs use em:foo attributes on <em:Description> to communicate their data.

For them to be installable in tests, we need to parse those, too, and not just child nodes.

Comment 1

[Axel Hecht [:Pike]]

Attachment: MozReview Request: bug 1198228, support em:foo attributes on Description elements, r=whimboo

bug 1198228, support em:foo attributes on Description elements, r=whimboo

The install.rdf in language packs uses em:id attributes etc, instead
of child elements. All fine with RDF/XML.
This adds support to addon_details to allow for those attributes in
addition to child elements.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8652801 [details]
MozReview Request: bug 1198228, support em:foo attributes on Description elements, r=whimboo

https://reviewboard.mozilla.org/r/17297/#review15343

Looks fine to me. Please make sure to run the change for Marionette unit tests for all major platforms on try.

Comment 3

[Axel Hecht [:Pike]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=57535a4d6377

Comment 4

[Axel Hecht [:Pike]]

Builds passed on osx, linux, win32, marking for check-in.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/379dd01ca525

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/379dd01ca525

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Axel, if that fix is important for you lets make sure we get a new release of mozprofile out. Just let me know.

Comment 8

[Axel Hecht [:Pike]]

(In reply to Henrik Skupin (:whimboo) from comment #7)
> Axel, if that fix is important for you lets make sure we get a new release
> of mozprofile out. Just let me know.

Yes, that would be helpful, thanks.