Closed Bug 1198229 Opened 7 years ago Closed 7 years ago

GCLI: rename securityDesc in gclicommands.properties to reflect new content

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: flod, Assigned: kmckinley)

References

Details

Attachments

(1 file, 2 obsolete files)

Please do not change strings without changing the associated IDs

http://hg.mozilla.org/mozilla-central/diff/d9ac2969f3bb/toolkit/locales/en-US/chrome/global/devtools/gclicommands.properties

securityDesc=Display supported security features
securityDesc=Display supported security and privacy features

Reference: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Summary: GCLI: rename to reflect new content → GCLI: rename securityDesc in gclicommands.properties to reflect new content
(In reply to Francesco Lodolo [:flod] from comment #0)
> Please do not change strings without changing the associated IDs
> 
> http://hg.mozilla.org/mozilla-central/diff/d9ac2969f3bb/toolkit/locales/en-
> US/chrome/global/devtools/gclicommands.properties

Oh Sorry, I didn't know that actually. Kate, can you fix that up please?
Assignee: nobody → kmckinley
Status: NEW → ASSIGNED
Attachment #8652421 - Flags: review?(mozilla)
Attachment #8652421 - Flags: review?(francesco.lodolo)
Comment on attachment 8652421 [details] [diff] [review]
GCLI: rename securityDesc in gclicommands.properties to reflect new content

Review of attachment 8652421 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good as long as you remove the old string.

::: toolkit/locales/en-US/chrome/global/devtools/gclicommands.properties
@@ +1573,5 @@
>  # The argument (%1$S) is the folder path.
>  folderOpenDirResult=Opened %1$S
>  
>  # LOCALIZATION NOTE (security)
> +securityDesc=Display supported security features

This string is not used anymore, simply leave the new one.
Attachment #8652421 - Flags: review?(francesco.lodolo) → feedback+
Attachment #8652435 - Flags: review?(mozilla)
Attachment #8652435 - Flags: review?(francesco.lodolo)
Attachment #8652421 - Attachment is obsolete: true
Attachment #8652421 - Flags: review?(mozilla)
Comment on attachment 8652435 [details] [diff] [review]
GCLI: rename securityDesc in gclicommands.properties to reflect new content

Review of attachment 8652435 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Kate!
Attachment #8652435 - Flags: review?(mozilla) → review+
Comment on attachment 8652435 [details] [diff] [review]
GCLI: rename securityDesc in gclicommands.properties to reflect new content

Review of attachment 8652435 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #8652435 - Flags: review?(francesco.lodolo) → review+
Attachment #8652435 - Attachment is obsolete: true
Comment on attachment 8652444 [details] [diff] [review]
GCLI: rename securityDesc in gclicommands.properties to reflect new content (

Review of attachment 8652444 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over previous r+
Attachment #8652444 - Flags: review?(mozilla)
Attachment #8652444 - Flags: review?(francesco.lodolo)
Attachment #8652444 - Flags: review+
Try not needed since the only change was to l10n variable name.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0aa386a944f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.