"Harness status: OK" + failing test when running "fetch-event-network-error.https.html" test

RESOLVED FIXED in Firefox 43

Status

Testing
web-platform-tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: noemi, Assigned: nsm)

Tracking

Trunk
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Checked with in m-c, ba43a48d3c52 revision.

Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/fetch-event-network-error.https.html|

Result:
Summary

Harness status: OK

Found 1 tests
1 Fail
Details
*Result	
**Fail

*Test Name
**Rejecting the fetch event or using preventDefault() causes a network error	assert_equals: expected "PASS" but got "FAIL: prevent-default: expected network error but loaded"

*Message
**@https://web-platform.test:8443/_mozilla/service-workers/service-worker/fetch-event-network-error.https.html:37:11
promise callback*@https://web-platform.test:8443/_mozilla/service-workers/service-worker/fetch-event-network-error.https.html:24:1
Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1380:20
promise callback*promise_test@https://web-platform.test:8443/resources/testharness.js:526:31
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/fetch-event-network-error.https.html:19:1

*Traces: https://pastebin.mozilla.org/8843830
(Reporter)

Updated

2 years ago
See Also: → bug 1179399
Created attachment 8657271 [details]
MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

Bug 1198230 - Respect FetchEvent.preventDefault(). r?jdm

Update web-platform-tests expected data
Attachment #8657271 - Flags: review?(josh)

Updated

2 years ago
Attachment #8657271 - Flags: review?(josh)

Comment 3

2 years ago
Comment on attachment 8657271 [details]
MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

https://reviewboard.mozilla.org/r/18349/#review16429

::: xpcom/base/ErrorList.h:337
(Diff revision 1)
> +  ERROR(NS_ERROR_INTERCEPTION_CANCELED,   FAILURE(106)),

nit: match the spacing for FAILURE

Also, why is this important to differentiate?

Comment 4

2 years ago
If you're adding a new interception error code, can you please consider if it should be handled here or in another docshell case?

  https://dxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp?case=true&from=nsDocShell.cpp#4967

Right now I think a canceled navigation will have bad UX.  Maybe netReset?
Comment on attachment 8657271 [details]
MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

Update web-platform-tests expected data
Attachment #8657271 - Attachment description: MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r?jdm → MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm
Attachment #8657271 - Flags: review?(josh)
Comment on attachment 8657271 [details]
MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

Update web-platform-tests expected data
Attachment #8657271 - Flags: review?(josh)
Comment on attachment 8657271 [details]
MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

r=jdm on IRC. he forgot to check "Ship It".
Attachment #8657271 - Flags: review+
Keywords: checkin-needed
Comment on attachment 8657271 [details]
MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm

Update web-platform-tests expected data
jdm isn't a peer or owner of dom/workers. If the Modules page is out of date, can you please update it or have someone who does have review permissions grant review?
Flags: needinfo?(nsm.nikhil)
Keywords: checkin-needed
jdm isn't a worker peer, but this change is only in dom/workers because it is related to Service Workers. jdm is the author of the interception event setup we use for Service Workers, which is what this patch modifies.
Flags: needinfo?(nsm.nikhil)
(Reporter)

Comment 15

2 years ago
Since the patch has been provided by Nikhil assigning this to him, please feel free to change it as needed. Thanks!
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Cheers. Could you refresh the patch please? It doesn't apply anymore.
(In reply to Nigel Babu [:nigelb] from comment #16)
> Cheers. Could you refresh the patch please? It doesn't apply anymore.

I'm just going to land this with other patches when the tree is open. I could have swore I landed this yesterday, but apparently not :(. Thanks!
https://hg.mozilla.org/mozilla-central/rev/b892adb39601
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
(Reporter)

Comment 20

2 years ago
Hi,

just checked on m-c (19f806034f67 revision) and the tes successfully runs. Thanks for fixing it!.

Summary

Harness status: OK

Found 1 tests
1 Pass
Details
Result	Test Name
Pass	Rejecting the fetch event or using preventDefault() causes a network error
You need to log in before you can comment on or make changes to this bug.