Closed
Bug 1198230
Opened 9 years ago
Closed 9 years ago
"Harness status: OK" + failing test when running "fetch-event-network-error.https.html" test
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: noemi, Assigned: nsm)
References
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
Details |
Checked with in m-c, ba43a48d3c52 revision. Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/fetch-event-network-error.https.html| Result: Summary Harness status: OK Found 1 tests 1 Fail Details *Result **Fail *Test Name **Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: prevent-default: expected network error but loaded" *Message **@https://web-platform.test:8443/_mozilla/service-workers/service-worker/fetch-event-network-error.https.html:37:11 promise callback*@https://web-platform.test:8443/_mozilla/service-workers/service-worker/fetch-event-network-error.https.html:24:1 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1380:20 promise callback*promise_test@https://web-platform.test:8443/resources/testharness.js:526:31 @https://web-platform.test:8443/_mozilla/service-workers/service-worker/fetch-event-network-error.https.html:19:1 *Traces: https://pastebin.mozilla.org/8843830
Assignee | ||
Comment 1•9 years ago
|
||
Waiting on https://github.com/slightlyoff/ServiceWorker/issues/741.
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1198230 - Respect FetchEvent.preventDefault(). r?jdm Update web-platform-tests expected data
Attachment #8657271 -
Flags: review?(josh)
Updated•9 years ago
|
Attachment #8657271 -
Flags: review?(josh)
Comment 3•9 years ago
|
||
Comment on attachment 8657271 [details] MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm https://reviewboard.mozilla.org/r/18349/#review16429 ::: xpcom/base/ErrorList.h:337 (Diff revision 1) > + ERROR(NS_ERROR_INTERCEPTION_CANCELED, FAILURE(106)), nit: match the spacing for FAILURE Also, why is this important to differentiate?
Comment 4•9 years ago
|
||
If you're adding a new interception error code, can you please consider if it should be handled here or in another docshell case? https://dxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp?case=true&from=nsDocShell.cpp#4967 Right now I think a canceled navigation will have bad UX. Maybe netReset?
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c25e32dc51d
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9efa362d4f0e Added nsDocShell cases.
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8657271 [details] MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm Update web-platform-tests expected data
Attachment #8657271 -
Attachment description: MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r?jdm → MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm
Attachment #8657271 -
Flags: review?(josh)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8657271 [details] MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm Update web-platform-tests expected data
Attachment #8657271 -
Flags: review?(josh)
Comment 9•9 years ago
|
||
You also need to update nsContentUtils: https://dxr.mozilla.org/mozilla-central/source/dom/base/nsContentUtils.cpp#3445
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8657271 [details] MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm r=jdm on IRC. he forgot to check "Ship It".
Attachment #8657271 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 11•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cbacbd82f5c with additions for nsContentUtils and localized string.
Assignee | ||
Updated•9 years ago
|
Attachment #8657271 -
Flags: review+
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8657271 [details] MozReview Request: Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm Bug 1198230 - Respect FetchEvent.preventDefault(). r=jdm Update web-platform-tests expected data
Comment 13•9 years ago
|
||
jdm isn't a peer or owner of dom/workers. If the Modules page is out of date, can you please update it or have someone who does have review permissions grant review?
Flags: needinfo?(nsm.nikhil)
Keywords: checkin-needed
Assignee | ||
Comment 14•9 years ago
|
||
jdm isn't a worker peer, but this change is only in dom/workers because it is related to Service Workers. jdm is the author of the interception event setup we use for Service Workers, which is what this patch modifies.
Flags: needinfo?(nsm.nikhil)
Reporter | ||
Comment 15•9 years ago
|
||
Since the patch has been provided by Nikhil assigning this to him, please feel free to change it as needed. Thanks!
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Comment 16•9 years ago
|
||
Cheers. Could you refresh the patch please? It doesn't apply anymore.
Assignee | ||
Comment 17•9 years ago
|
||
(In reply to Nigel Babu [:nigelb] from comment #16) > Cheers. Could you refresh the patch please? It doesn't apply anymore. I'm just going to land this with other patches when the tree is open. I could have swore I landed this yesterday, but apparently not :(. Thanks!
Comment 19•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b892adb39601
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Reporter | ||
Comment 20•9 years ago
|
||
Hi, just checked on m-c (19f806034f67 revision) and the tes successfully runs. Thanks for fixing it!. Summary Harness status: OK Found 1 tests 1 Pass Details Result Test Name Pass Rejecting the fetch event or using preventDefault() causes a network error
You need to log in
before you can comment on or make changes to this bug.
Description
•