1198244 - Audit multi-line addEventListener...bind( callers for leaking/broken add/removeEventListener pairs

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

Spun off from bug 1185893. Besides the other items that are still on file, and some that I checked already, here's the complete list of grepping through browser/ and toolkit/ :


browser/devtools/eyedropper/eyedropper.js:    closeCmd.addEventListener("command", this.destroy.bind(this), true);
browser/devtools/eyedropper/eyedropper.js:    copyCmd.addEventListener("command", this.selectColor.bind(this), true);
browser/devtools/framework/toolbox-options.js:      checkbox.addEventListener("command", onCheckboxClick.bind(this, checkbox));
browser/devtools/framework/toolbox-options.js:      checkbox.addEventListener("command", onCheckboxClick.bind(checkbox, tool.id));
browser/devtools/framework/toolbox.js:    nextKey.addEventListener("command", this.selectNextTool.bind(this), true);
browser/devtools/framework/toolbox.js:    prevKey.addEventListener("command", this.selectPreviousTool.bind(this), true);
browser/devtools/framework/toolbox.js:    toggleKey.addEventListener("command", this.switchToPreviousHost.bind(this), true);
browser/devtools/framework/toolbox.js:    inKey.addEventListener("command", this.zoomIn.bind(this), true);
browser/devtools/framework/toolbox.js:    inKey2.addEventListener("command", this.zoomIn.bind(this), true);
browser/devtools/framework/toolbox.js:    outKey.addEventListener("command", this.zoomOut.bind(this), true);
browser/devtools/framework/toolbox.js:    resetKey.addEventListener("command", this.zoomReset.bind(this), true);
browser/devtools/scratchpad/scratchpad.js:        menuitem.addEventListener("command", Scratchpad.openFile.bind(Scratchpad, i));
browser/devtools/scratchpad/scratchpad.js:addEventListener("load", Scratchpad.onLoad.bind(Scratchpad), false);
browser/devtools/scratchpad/scratchpad.js:addEventListener("unload", Scratchpad.onUnload.bind(Scratchpad), false);
browser/devtools/scratchpad/scratchpad.js:addEventListener("close", Scratchpad.onClose.bind(Scratchpad), false);
browser/devtools/shared/widgets/BreadcrumbsWidget.jsm:  this._list.addEventListener("underflow", this._onUnderflow.bind(this), false);
browser/devtools/shared/widgets/BreadcrumbsWidget.jsm:  this._list.addEventListener("overflow", this._onOverflow.bind(this), false);
browser/devtools/shared/widgets/Chart.jsm:    node.addEventListener(event, emitter.emit.bind(emitter, event, args));
browser/devtools/shared/widgets/VariablesView.jsm:      editNode.addEventListener("mousedown", this._onEdit.bind(this), false);
browser/devtools/shared/widgets/VariablesView.jsm:      deleteNode.addEventListener("click", this._onDelete.bind(this), false);
browser/devtools/shared/widgets/VariablesView.jsm:      addPropertyNode.addEventListener("mousedown", this._onAddProperty.bind(this), false);
browser/devtools/styleeditor/StyleEditorUI.jsm:        div.addEventListener("click", this._jumpToLocation.bind(this, location));
browser/devtools/tilt/tilt.js:    this.chromeWindow.gBrowser.tabContainer.addEventListener(
      "TabSelect", this._onTabSelect.bind(this), false);
browser/devtools/webconsole/console-output.js:    anchor.addEventListener("contextmenu", options.onContextMenu.bind(this));
browser/devtools/webconsole/network-panel.js:        a.addEventListener("mousedown", this._longStringClick.bind(this, aItem));
browser/devtools/webide/content/simulator.js:      form.addEventListener("change", this.update.bind(this));
browser/devtools/webide/modules/runtime-list.js:          configButton.addEventListener("click", r.configure.bind(r), true);
browser/extensions/pdfjs/content/web/viewer.js:        element.addEventListener('click', elements[item].handler.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:      toggleHandTool.addEventListener('click', this.toggle.bind(this), false);
browser/extensions/pdfjs/content/web/viewer.js:    this.passwordSubmit.addEventListener('click',
      this.verifyPassword.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:    this.passwordCancel.addEventListener('click', this.close.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:      options.closeButton.addEventListener('click', this.close.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('presentationMode').addEventListener('click',
    SecondaryToolbar.presentationModeClick.bind(SecondaryToolbar));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('openFile').addEventListener('click',
    SecondaryToolbar.openFileClick.bind(SecondaryToolbar));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('print').addEventListener('click',
    SecondaryToolbar.printClick.bind(SecondaryToolbar));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('download').addEventListener('click',
    SecondaryToolbar.downloadClick.bind(SecondaryToolbar));
browser/extensions/shumway/content/shumway.gfx.js:            window.addEventListener("resize", this._onResize.bind(this));
browser/extensions/shumway/content/shumway.gfx.js:          window.addEventListener("resize", this._resizeHandler.bind(this), !1);
browser/extensions/shumway/content/shumway.gfx.js:        this._easel.addEventListener("resize", this._resizeEventListener.bind(this));
browser/extensions/shumway/content/shumway.player.js:            window.addEventListener("resize", this._onResize.bind(this));
browser/extensions/shumway/content/shumway.player.js:          window.addEventListener("resize", this._resizeHandler.bind(this), !1);
browser/extensions/shumway/content/shumway.player.js:              this._mediaSource.addEventListener("sourceopen", this._openMediaSource.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(e.OPEN, this.onStreamOpen.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(e.COMPLETE, this.onStreamComplete.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(d.PROGRESS, this.onStreamProgress.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(l.IO_ERROR, this.onStreamIOError.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(a.HTTP_STATUS, this.onStreamHTTPStatus.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(a.HTTP_RESPONSE_STATUS, this.onStreamHTTPResponseStatus.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(c.SECURITY_ERROR, this.onStreamSecurityError.bind(this));
browser/extensions/shumway/content/shumway.player.js:            d.addEventListener("addedToStage", this._addListeners.bind(this));
browser/extensions/shumway/content/shumway.player.js:            d.addEventListener("removedFromStage", this._removeListeners.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.Event.OPEN, this.openHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.ProgressEvent.PROGRESS, this.progressHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.IOErrorEvent.IO_ERROR, this.ioErrorHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.Event.COMPLETE, this.completeHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.Event.INIT, this.initHandler.bind(this));


toolkit/components/passwordmgr/content/passwordManager.js:  treecols.addEventListener("click", HandleTreeColumnClick.bind(null, SignonColumnSort));
toolkit/components/passwordmgr/content/passwordManagerExceptions.js:  treecols.addEventListener("click", HandleTreeColumnClick.bind(null, RejectColumnSort));
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button0.addEventListener("command", this.onButtonClick.bind(this, 0), false);
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button1.addEventListener("command", this.onButtonClick.bind(this, 1), false);
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button2.addEventListener("command", this.onButtonClick.bind(this, 2), false);
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button3.addEventListener("command", this.onButtonClick.bind(this, 3), false);
toolkit/components/search/SearchSuggestionController.jsm:    this._request.addEventListener("load", this._onRemoteLoaded.bind(this, deferredResponse));
toolkit/components/viewsource/content/viewSourceUtils.js:          webNavigation.document.addEventListener("DOMContentLoaded",
                                                  this.onContentLoaded.bind(this));
toolkit/content/aboutwebrtc/aboutWebrtc.js:    ctrl.addEventListener("click", this.onClick.bind(this));
toolkit/mozapps/extensions/content/setting.xml:        this.control.addEventListener("command", this.inputChanged.bind(this), false);



Not all of these are going to be wrong (in fact, probably very many never get removed, in which case we do nothing here right now) but it'd be good to go through them and figure out which ones are.

Comment 1

[:Gijs (he/him)]

Went through until the end of the devtools list, filed one bug about a duplicate bind(), didn't find anything else so far.

Comment 2

[:Gijs (he/him)]

browser/extensions/pdfjs/content/web/viewer.js:        element.addEventListener('click', elements[item].handler.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:      toggleHandTool.addEventListener('click', this.toggle.bind(this), false);
browser/extensions/pdfjs/content/web/viewer.js:    this.passwordSubmit.addEventListener('click',
      this.verifyPassword.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:    this.passwordCancel.addEventListener('click', this.close.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:      options.closeButton.addEventListener('click', this.close.bind(this));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('presentationMode').addEventListener('click',
    SecondaryToolbar.presentationModeClick.bind(SecondaryToolbar));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('openFile').addEventListener('click',
    SecondaryToolbar.openFileClick.bind(SecondaryToolbar));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('print').addEventListener('click',
    SecondaryToolbar.printClick.bind(SecondaryToolbar));
browser/extensions/pdfjs/content/web/viewer.js:  document.getElementById('download').addEventListener('click',
    SecondaryToolbar.downloadClick.bind(SecondaryToolbar));
browser/extensions/shumway/content/shumway.gfx.js:            window.addEventListener("resize", this._onResize.bind(this));
browser/extensions/shumway/content/shumway.gfx.js:          window.addEventListener("resize", this._resizeHandler.bind(this), !1);
browser/extensions/shumway/content/shumway.gfx.js:        this._easel.addEventListener("resize", this._resizeEventListener.bind(this));
browser/extensions/shumway/content/shumway.player.js:            window.addEventListener("resize", this._onResize.bind(this));
browser/extensions/shumway/content/shumway.player.js:          window.addEventListener("resize", this._resizeHandler.bind(this), !1);
browser/extensions/shumway/content/shumway.player.js:              this._mediaSource.addEventListener("sourceopen", this._openMediaSource.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(e.OPEN, this.onStreamOpen.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(e.COMPLETE, this.onStreamComplete.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(d.PROGRESS, this.onStreamProgress.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(l.IO_ERROR, this.onStreamIOError.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(a.HTTP_STATUS, this.onStreamHTTPStatus.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(a.HTTP_RESPONSE_STATUS, this.onStreamHTTPResponseStatus.bind(this));
browser/extensions/shumway/content/shumway.player.js:              q.addEventListener(c.SECURITY_ERROR, this.onStreamSecurityError.bind(this));
browser/extensions/shumway/content/shumway.player.js:            d.addEventListener("addedToStage", this._addListeners.bind(this));
browser/extensions/shumway/content/shumway.player.js:            d.addEventListener("removedFromStage", this._removeListeners.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.Event.OPEN, this.openHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.ProgressEvent.PROGRESS, this.progressHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.IOErrorEvent.IO_ERROR, this.ioErrorHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.Event.COMPLETE, this.completeHandler.bind(this));
browser/extensions/shumway/content/shumway.player.js:          this._loader.contentLoaderInfo.addEventListener(n.events.Event.INIT, this.initHandler.bind(this));
toolkit/components/passwordmgr/content/passwordManager.js:  treecols.addEventListener("click", HandleTreeColumnClick.bind(null, SignonColumnSort));
toolkit/components/passwordmgr/content/passwordManagerExceptions.js:  treecols.addEventListener("click", HandleTreeColumnClick.bind(null, RejectColumnSort));
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button0.addEventListener("command", this.onButtonClick.bind(this, 0), false);
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button1.addEventListener("command", this.onButtonClick.bind(this, 1), false);
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button2.addEventListener("command", this.onButtonClick.bind(this, 2), false);
toolkit/components/prompts/content/tabprompts.xml:            this.ui.button3.addEventListener("command", this.onButtonClick.bind(this, 3), false);
toolkit/components/search/SearchSuggestionController.jsm:    this._request.addEventListener("load", this._onRemoteLoaded.bind(this, deferredResponse));
toolkit/components/viewsource/content/viewSourceUtils.js:          webNavigation.document.addEventListener("DOMContentLoaded",
                                                  this.onContentLoaded.bind(this));
toolkit/content/aboutwebrtc/aboutWebrtc.js:    ctrl.addEventListener("click", this.onClick.bind(this));
toolkit/mozapps/extensions/content/setting.xml:        this.control.addEventListener("command", this.inputChanged.bind(this), false);

Comment 3

[:Gijs (he/him)]

Annnd we're done.