Closed Bug 1198247 Opened 4 years ago Closed 4 years ago

_psutil_osx.so and _psutil_posix.so show as untracked files for git status after a build

Categories

(Firefox Build System :: General, defect)

33 Branch
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

I suspect this is a regression from bug 1196253. When I do git status after a build I'm now seeing:

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	python/psutil/psutil/_psutil_osx.so
	python/psutil/psutil/_psutil_posix.so

(This is a build on Mac using latest fx-team).
I just deleted my ignored files related to psutil, rebuilt, and was unable to confirm that `hg status` was reporting the .so files, as mentioned in the summary line. I don't have a Git checkout to confirm behavior there.
Ah sorry, I somehow got my reading wrong and thought this did include Mercurial. I now have a patch for this though ;-)
Assignee: nobody → standard8
Summary: _psutil_osx.so and _psutil_posix.so show as untracked files for git status or hg status after a build → _psutil_osx.so and _psutil_posix.so show as untracked files for git status after a build
According to http://git-scm.com/book/en/v2/Git-Basics-Recording-Changes-to-the-Repository#Ignoring-Files, using /**/ matches nested directories. Therefore doing this should be good for both the old & new locations.

The hg version gets away with this as it uses .*
Attachment #8652374 - Flags: review?(gps)
Comment on attachment 8652374 [details] [diff] [review]
Update .gitignore for moved locations of psutil build files.

Review of attachment 8652374 [details] [diff] [review]:
-----------------------------------------------------------------

Color me surprised that nobody has reported this before now.
Attachment #8652374 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/cc338000e610
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.