1198257 - Improve support for providing a directory name on the command line and discovering reftests in that directory

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[James Graham [:jgraham]]

This is a followup to bug 1181516 that makes it possible to pass in a directory like dom/ to the reftest harness and run tests under that directory, even if it doesn't actually contain a reftest.list directly.

Comment 1

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8652338 [details]
MozReview Request: Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

https://reviewboard.mozilla.org/r/17125/#review15253

only 1 question here.

::: layout/tools/reftest/runreftest.py:195
(Diff revision 1)
> -
> +                manifests[key] = None

why do you set the key = None?  is this in case manifests[key] is a different type which includes None?

Comment 3

[James Graham [:jgraham]]

https://reviewboard.mozilla.org/r/17125/#review15253

> why do you set the key = None?  is this in case manifests[key] is a different type which includes None?

Well if the list includes None it signals that we should match all tests in that manifest. In that case I explicitly set the filter to None (null on the js side), rather than passing through a filter that would match all tests (e.g. ""). I suppose either approach is possible and has some small advnatages/disadvantages. This is more explicit but the other setup would avoid a special case.

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8652338 [details]
MozReview Request: Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8652338 [details]
MozReview Request: Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

https://reviewboard.mozilla.org/r/17125/#review15763

thanks jgraham

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb2d48b71c37

Comment 7

[Carsten Book [:Tomcat]]

sorry had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/5a8d86582839 since one of this changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=13953993&repo=mozilla-inbound

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24f4ad5c55cc

Comment 9

[Nigel Babu [:nigelb]]

Had to back it out in https://hg.mozilla.org/integration/mozilla-inbound/rev/fa0a54cadfd0 for failures on Android 4.0 API11 reftests that look like this https://treeherder.mozilla.org/logviewer.html#?job_id=14037560&repo=mozilla-inbound

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf1271f6cfa0

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for breaking Android 4.0 debug reftests
https://hg.mozilla.org/integration/mozilla-inbound/rev/d90bfbc8688a

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70708e14dceb

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/70708e14dceb