Closed Bug 1198257 Opened 4 years ago Closed 4 years ago

Improve support for providing a directory name on the command line and discovering reftests in that directory

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jgraham, Unassigned)

References

Details

Attachments

(1 file)

This is a followup to bug 1181516 that makes it possible to pass in a directory like dom/ to the reftest harness and run tests under that directory, even if it doesn't actually contain a reftest.list directly.
Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory
Attachment #8652338 - Flags: review?(jmaher)
Comment on attachment 8652338 [details]
MozReview Request: Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

https://reviewboard.mozilla.org/r/17125/#review15253

only 1 question here.

::: layout/tools/reftest/runreftest.py:195
(Diff revision 1)
> -
> +                manifests[key] = None

why do you set the key = None?  is this in case manifests[key] is a different type which includes None?
Attachment #8652338 - Flags: review?(jmaher)
https://reviewboard.mozilla.org/r/17125/#review15253

> why do you set the key = None?  is this in case manifests[key] is a different type which includes None?

Well if the list includes None it signals that we should match all tests in that manifest. In that case I explicitly set the filter to None (null on the js side), rather than passing through a filter that would match all tests (e.g. ""). I suppose either approach is possible and has some small advnatages/disadvantages. This is more explicit but the other setup would avoid a special case.
Comment on attachment 8652338 [details]
MozReview Request: Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory
Attachment #8652338 - Flags: review?(jmaher)
Comment on attachment 8652338 [details]
MozReview Request: Bug 1198257 - Better support for providing a directory name and discovering reftests under that directory

https://reviewboard.mozilla.org/r/17125/#review15763

thanks jgraham
Attachment #8652338 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/70708e14dceb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.