Closed
Bug 1198264
Opened 9 years ago
Closed 9 years ago
Check in regression test for bug 1190791
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
Details
Attachments
(1 file)
For bug 1190791, I made an automated test that triggered the issue that could be seen there. It was decided it was a good idea to get this checked into our automation suite, so we find out very quickly when/if the issue in bug 1190791 would regress again. The pull request is here: https://github.com/mozilla-b2g/gaia/pull/31439 I only need to figure out in what functional test area I should put this.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8652806 [details] [review] [gaia] mwargers:1198264 > mozilla-b2g:master Ok, like this then?
Attachment #8652806 -
Flags: review?(npark)
Attachment #8652806 -
Flags: review?(jlorenzo)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8652806 [details] [review] [gaia] mwargers:1198264 > mozilla-b2g:master r+ modulo the magic number which needs a bit more of details.
Attachment #8652806 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Updated the comment to say something about the number as well.
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8652806 [details] [review] [gaia] mwargers:1198264 > mozilla-b2g:master Oh, so it was caused by wifi connection I see. LGTM
Attachment #8652806 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Hrm, in the latest Flame build, I still get failures as in bug 1190791 with the test. I guess the fix for bug 1196884 has not landed downstream yet.
|
|
Assignee | |
Comment 7•9 years ago
|
||
Bug 1196884 is already fixed since 2015-08-21, but I can still reproduce the issue. So better to not check it in.
|
|
Assignee | |
Comment 8•9 years ago
|
||
(In reply to Martijn Wargers [:mwargers] (QA) from comment #7) > Bug 1196884 is already fixed since 2015-08-21, but I can still reproduce the > issue. So better to not check it in. I've now filed bug 1200271 for this.
Depends on: 1200271
|
|
Assignee | |
Comment 9•9 years ago
|
||
It turns out that I had to do a full flash on the Flame device, and then bug 1200271 didn't occur. Merged: https://github.com/mozilla-b2g/gaia/commit/876ba1b656d924b3e47e207330367dfc41486151
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•