1198327 - [Rule View] Adding new unmatched rule does not go to new property editor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

STR:
1. Add an unmatched rule, finish editing the selector and enter
2. Notice a new property editor is not created

Expected:
A new property editor should be created

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1198327.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd1f5bf56149

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8655087 [details] [diff] [review]
1198327.patch

Review of attachment 8655087 [details] [diff] [review]:
-----------------------------------------------------------------

Let's discuss further if you don't like the suggestion

::: browser/devtools/styleinspector/rule-view.js
@@ +2871,5 @@
>            ruleView.highlightedSelector === this.rule.selectorText) {
>          ruleView.toggleSelectorHighlighter(ruleView.lastSelectorIcon,
>            ruleView.highlightedSelector);
>        }
> +      this._moveSelectorFocus(editor, direction);

Could you instead change this line to editor._moveSelectorFocus(newRule, direction) and not make any changes to _moveSelectorFocus?

It looks like that would have the same effect, but then _moveSelectorFocus could keep the more straightforward interface.  In fact, it seems like the Rule argument in _moveSelectorFocus could be removed and could be accessed via this.rule (which would be newRule if you called it on editor in this scope).

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1198327.patch [1.0]

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb071ca99d0a

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b5ef40e401b6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5ef40e401b6