Closed Bug 1198364 Opened 4 years ago Closed 4 years ago

test_TelemetrySend.js, test_TelemetryReportingPolicy.js test failures if FHR upload pref not set

Categories

(Toolkit :: Telemetry, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox41 --- fixed
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file, 1 obsolete file)

The same pref issue as bug 1197612 also causes these test failures on c-c:
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | xpcshell return code: 0
TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_TelemetryReportingPolicy.js | Test timed out
Attached patch telemetrytests2.diff (obsolete) — Splinter Review
Attachment #8652432 - Flags: review?(gfritzsche)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8652432 [details] [diff] [review]
telemetrytests2.diff

Review of attachment 8652432 [details] [diff] [review]:
-----------------------------------------------------------------

I think before we start doing this across more individual tests we should check if we can just do this once here:
https://dxr.mozilla.org/mozilla-central/rev/c46370eea81a9860ae77d1f0c7776c24e816138e/toolkit/components/telemetry/tests/unit/head.js#324
Attachment #8652432 - Flags: review?(gfritzsche)
Good idea! Seems to work.
Attachment #8652432 - Attachment is obsolete: true
Attachment #8652818 - Flags: review?(gfritzsche)
Comment on attachment 8652818 [details] [diff] [review]
telemetryhead.diff

Review of attachment 8652818 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good to me - but we should definitely do a full try run before landing to avoid fallout on odd configurations etc.
Attachment #8652818 - Flags: review?(gfritzsche) → review+
(In reply to aleth [:aleth] from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=52e6c9fb33a3

Looks OK to me.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b93c557d50b8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8652818 [details] [diff] [review]
telemetryhead.diff

Approval Request Comment
[Feature/regressing bug #]: telemetry tests
[User impact if declined]: comm tests fail
[Describe test coverage new/current, TreeHerder]: works on c-c
[Risks and why]: none expected, test only
[String/UUID change made/needed]: none
Attachment #8652818 - Flags: approval-mozilla-beta?
Attachment #8652818 - Flags: approval-mozilla-aurora?
Comment on attachment 8652818 [details] [diff] [review]
telemetryhead.diff

Test only change. Aurora42+, Beta41+
Attachment #8652818 - Flags: approval-mozilla-beta?
Attachment #8652818 - Flags: approval-mozilla-beta+
Attachment #8652818 - Flags: approval-mozilla-aurora?
Attachment #8652818 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.