Closed
Bug 119837
Opened 23 years ago
Closed 23 years ago
Add an isOverridable parameter to GetMinimumWidgetSize
Categories
(Core Graveyard :: Skinability, defect)
Core Graveyard
Skinability
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file, 1 obsolete file)
|
6.08 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
We need to add a parameter to GetMinimumWidgetSize to specify that the skin should not be able to override the min-width/min-height. This will fix the problem on GTK that the skin gives a min-width of 16px for scrollbar buttons, but most themes have narrow scrollbar buttons.
|
Assignee | |
Comment 1•23 years ago
|
||
|
||
Comment 2•23 years ago
|
||
This isn't right. Patch the CSS check, not the fucked up attribute check.
|
|
||
Comment 3•23 years ago
|
||
This isn't right. Patch the CSS check, not the fucked up attribute check.
|
|
||
Comment 4•23 years ago
|
||
Ignore my double post. :)
|
|
Assignee | |
Comment 5•23 years ago
|
||
Attachment #64776 -
Attachment is obsolete: true
|
|
||
Comment 6•23 years ago
|
||
sr=hyatt on the second patch.
|
||
Comment 7•23 years ago
|
||
Comment on attachment 64777 [details] [diff] [review] new patch r=bzbarsky. Changes look fine and don't actually change how anything acts yet...
Attachment #64777 -
Flags: superreview+
Attachment #64777 -
Flags: review+
|
|
Assignee | |
Comment 8•23 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•