Add an isOverridable parameter to GetMinimumWidgetSize

VERIFIED FIXED

Status

Core Graveyard
Skinability
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

17 years ago
We need to add a parameter to GetMinimumWidgetSize to specify that the skin
should not be able to override the min-width/min-height.  This will fix the
problem on GTK that the skin gives a min-width of 16px for scrollbar buttons,
but most themes have narrow scrollbar buttons.

Comment 2

17 years ago
This isn't right.  Patch the CSS check, not the fucked up attribute check.

Comment 3

17 years ago
This isn't right.  Patch the CSS check, not the fucked up attribute check.

Comment 4

17 years ago
Ignore my double post. :)
(Assignee)

Comment 5

17 years ago
Created attachment 64777 [details] [diff] [review]
new patch
Attachment #64776 - Attachment is obsolete: true

Comment 6

17 years ago
sr=hyatt on the second patch.
Comment on attachment 64777 [details] [diff] [review]
new patch

r=bzbarsky.  Changes look fine and don't actually change how anything acts
yet...
Attachment #64777 - Flags: superreview+
Attachment #64777 - Flags: review+
(Assignee)

Comment 8

17 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
Verified the patch
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.