1198394 - Enable interception of secure upgraded channels in non-e10s mode

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[(no longer active)]

Those connections fall through nsHttpChannel::HandleAsyncRedirectChannelToHttps() which does an internal redirect which disables interception, so we currently do not intercept the HSTS upgraded channel.

Josh, can you please double check?

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Note, I'm in the process of changing some redirect stuff over in bug 1184607.  Not sure if that effects this or not, but just FYI.

Comment 2

[Josh Matthews [:jdm]]

Note: the fetch spec says that the request should be upgraded, and the upgraded request should have the regular interception steps applied to it.

Comment 3

[(no longer active)]

Resummarizing this bug to make it only cover the simple non-e10s case.  Filed bug 1214305 as a follow-up for e10s support.

Comment 4

[(no longer active)]

Attachment: Part 1: Allow interception of HSTS upgraded connections in non-e10s mode

Comment 5

[(no longer active)]

Attachment: Part 2: Add a test for interception of HSTS upgraded connections

Comment 6

[(no longer active)]

Josh: ping?

Comment 7

[Josh Matthews [:jdm]]

Comment on attachment 8673304 [details] [diff] [review]
Part 2: Add a test for interception of HSTS upgraded connections

Review of attachment 8673304 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/fetch/hsts/hsts_test.js
@@ +1,3 @@
> +self.addEventListener("fetch", function(event) {
> +  if (event.request.url.indexOf("index.html") >= 0) {
> +    event.respondWith(fetch("realindex.html"));

We should explicitly fail the case with "http://" to verify that the upgrade is occurring before the interception.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d60204230fb8
https://hg.mozilla.org/integration/mozilla-inbound/rev/2202e541c7b5

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d60204230fb8
https://hg.mozilla.org/mozilla-central/rev/2202e541c7b5

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d60204230fb8
https://hg.mozilla.org/mozilla-central/rev/2202e541c7b5