Closed Bug 1198394 Opened 4 years ago Closed 4 years ago

Enable interception of secure upgraded channels in non-e10s mode

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
e10s - ---
firefox44 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(2 files)

Those connections fall through nsHttpChannel::HandleAsyncRedirectChannelToHttps() which does an internal redirect which disables interception, so we currently do not intercept the HSTS upgraded channel.

Josh, can you please double check?
Flags: needinfo?(josh)
Note, I'm in the process of changing some redirect stuff over in bug 1184607.  Not sure if that effects this or not, but just FYI.
Assignee: nobody → josh
Flags: needinfo?(josh)
See Also: → 1198397
Assignee: josh → ehsan
Note: the fetch spec says that the request should be upgraded, and the upgraded request should have the regular interception steps applied to it.
Status: NEW → ASSIGNED
Depends on: 1206894
Blocks: 1198397
See Also: → 1214305
Resummarizing this bug to make it only cover the simple non-e10s case.  Filed bug 1214305 as a follow-up for e10s support.
Summary: We probably don't intercept HSTS upgraded channels → Enable interception of secure upgraded channels in non-e10s mode
Attachment #8673303 - Flags: review?(mcmanus) → review+
Josh: ping?
Comment on attachment 8673304 [details] [diff] [review]
Part 2: Add a test for interception of HSTS upgraded connections

Review of attachment 8673304 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/fetch/hsts/hsts_test.js
@@ +1,3 @@
> +self.addEventListener("fetch", function(event) {
> +  if (event.request.url.indexOf("index.html") >= 0) {
> +    event.respondWith(fetch("realindex.html"));

We should explicitly fail the case with "http://" to verify that the upgrade is occurring before the interception.
Attachment #8673304 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/d60204230fb8
https://hg.mozilla.org/mozilla-central/rev/2202e541c7b5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.