Closed Bug 1198395 Opened 9 years ago Closed 9 years ago

chrome.tabs.update reports "tabbrowser is undefined", and fails to update.

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: bwinton, Assigned: bwinton)

Details

Attachments

(1 file)

I'm starting to port Whimsy over to WebExtensions [0], and have run into a few problems, which I will be filing bugs for.  ;)

The first problem is that using chrome.tabs.update to change the active tab[1] doesn’t work, and instead throws a "tabbrowser is undefined" exception.

Patch to fix it coming soon.

[0] https://github.com/bwinton/whimsy/tree/WebExtensionAPI
[1] https://github.com/bwinton/whimsy/blob/WebExtensionAPI/lib/background.js#L10
Status: NEW → ASSIGNED
Attached patch chrome.tabs.diffSplinter Review
And here's the typo fix that makes it all work again.  :)
Attachment #8652469 - Flags: review?(wmccloskey)
Comment on attachment 8652469 [details] [diff] [review]
chrome.tabs.diff

Review of attachment 8652469 [details] [diff] [review]:
-----------------------------------------------------------------

Oops. Thanks!
Attachment #8652469 - Flags: review?(wmccloskey) → review+
(I'm getting a copy of mozilla-inbound now, but it's going to be a while, and may not complete before I have to leave for the day…)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d3a33dc8f1ff
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: