1198407 - Ignore app snapshot when background the app while displaying a private tab

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Stephan Leroux [:sleroux]]

We should obscure or hide the browser view while surfing in private mode when backgrounding the app so when the user is using the home app switcher, they don't see the private tab.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1059

Looks like the ignoreSnapshotOnNextLaunch method isn't for the app switcher but is for not showing a snapshot on the next app launch. Instead, I listen for app lifecycle notifications to determine if we should hide/show the url/web content depending on if we're in a private tab.

Also, anyone have any ideas on how we can write an automated test for this?

Darrin: Since we're just hiding the content and url, the backgrounded view of the app with a private tab open replaces the content with a large gray box. Any ideas on what we want to display instead?

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8659399 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1059

I think we could avoid subtle bugs if we hide the container instead of individual web views. LGTM otherwise.

(In reply to Stephan Leroux [:sleroux] from comment #1)
> Also, anyone have any ideas on how we can write an automated test for this?

Let me know if you find a good answer. I haven't really found any good way to test anything outside of the app sandbox (like pressing the home button).

Comment 3

[Stephan Leroux [:sleroux]]

Merged

Comment 4

[Catalin Suciu [:csuciu]]

Going to the app switcher while in pbmode shows:
- the content of the page replaced by a grey box
- no url in the url bar 

Verifying as fixed on Beta 1.1 (1103).