Just a minor console complaint I observed after PR902 landed for bug 1197550, when running locally under web-server.js, the console complains on the $http.get() per the attached screen grab. I did a re-provision and under vagrant it's fine. It just occurs under web-server. I defer to Mauro and Ed in case this is a wontfix :)
This is because the call here is missing a `thServiceDomain` prefix: https://github.com/mozilla/treeherder/blob/7af7496b18bf916bbacc51b1ead29c0daf9aa7b8/ui/js/directives/treeherder/persona.js#L24 That said, login won't work from web-server.js, since the requests will be cross-domain.
Perhaps we should just disable the login button (with some appropriate messaging) if `thServiceDomain !== ''` ?
Clearing priority so I revisit this during triage.
Priority: P5 → --
(In reply to Ed Morley [:emorley] from comment #3) > Perhaps we should just disable the login button (with some appropriate > messaging) if `thServiceDomain !== ''` ? Can that thServiceDomain condition occur on stage or prod? If it can only occur locally maybe it's simpler/less code to maintain to leave the ui as-is dunno. :-) I guess it currently gives us a workflow to test rejection of certain types of login attempts.
We no longer used browserid.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.