1198481 - fix id_pk_serverAuth typo in pkixcert.cpp

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

See https://dxr.mozilla.org/mozilla-central/rev/04b8c412d9f58fb6194c58dcaa66bf278bbd53cf/security/pkix/lib/pkixcert.cpp?offset=200#160

The "id_pk_serverAuth" should be "id_kp_serverAuth".

Comment 1

[manikishanghantasala]

I would like to take this over . I am a newbie?

Comment 2

[manikishanghantasala]

(In reply to manikishanghantasala from comment #1)
> I would like to take this over . I am a newbie.

Comment 3

[manikishanghantasala]

Attachment: bug-1198481

[Security approval request comment]
How easily could an exploit be constructed based on the patch?

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?

Which older supported branches are affected by this flaw?

If not all supported branches, which bug introduced the flaw?

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?

How likely is this patch to cause regressions; how much testing does it need?

Comment 4

[Al Billings [:abillings - ex-MoCo]]

Comment on attachment 8933903 [details]
bug-1198481

Settings sec-approval? on an unrated, public, non-security bug without answering any of the template questions isn't very useful.

Comment 5

[manikishanghantasala]

sorry I am new to this can you please help me explaining what should be done?

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

(In reply to manikishanghantasala from comment #5)
> sorry I am new to this can you please help me explaining what should be done?

Please don't change any further bug flags :)

The patch you uploaded is empty. When you have a new version ready, please upload it as type "patch" and ask for review? from :keeler. Then we can assign this one to you.

Comment 7

[manikishanghantasala]

Attachment: Bug-1198481.patch

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8934115 [details] [diff] [review]
Bug-1198481.patch

Review of attachment 8934115 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks!
Normally the next step would be to run this through try, but since this is a comment-only change, we can mark it `checkin-needed` directly.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8577d0b83990
Fixed typo 'id_pk_serverAuth' to 'id_kp_serverAuth'. r=keeler

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8577d0b83990