1198576 - Remove MediaCodecReader.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Benjamin Chen [:bechen]]

Since we prefer the PlatformDecoderModule and the emulator-kk tryserver progress is so slow. The MediaCodecReader won't be enable anymore.

I'm going to remove them once I have free time. Maybe middle of September.

Comment 1

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=409fcf34e017

Comment 2

[Benjamin Chen [:bechen]]

Attachment: bug-1198576.v02.patch

Comment 3

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5334c0d2ee78

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8685294 [details] [diff] [review]
bug-1198576.v02.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7883fc241cb5

Comment 5

[Blake Wu [:bwu][:blakewu]]

Comment on attachment 8685294 [details] [diff] [review]
bug-1198576.v02.patch

Review of attachment 8685294 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/DecoderTraits.cpp
@@ -650,5 @@
>    if (IsRtspSupportedType(aType)) {
> -#if ANDROID_VERSION >= 18
> -    decoder = MediaDecoder::IsOmxAsyncEnabled()
> -      ? static_cast<MediaDecoder*>(new RtspMediaCodecDecoder(aOwner))
> -      : static_cast<MediaDecoder*>(new RtspOmxDecoder(aOwner));

Does currently RTSP use MediaCodecDecoder? 
If yes, would it cause any problems in RTSP if we rollback to OmxDecoder?

Comment 6

[Blake Wu [:bwu][:blakewu]]

Comment on attachment 8685294 [details] [diff] [review]
bug-1198576.v02.patch

Review of attachment 8685294 [details] [diff] [review]:
-----------------------------------------------------------------

Per discussing offline with Benjamin, RTSP currently doesn't use MediaCodecDecoder due to pref off and we should remove that pref as well.
So cancel this review for next patch.

Comment 7

[Benjamin Chen [:bechen]]

Attachment: bug-1198576.v02.patch

Remove |MediaDecoder::IsOmxAsyncEnabled| function. And the preference never exist in b2g.js.

Comment 8

[Blake Wu [:bwu][:blakewu]]

Comment on attachment 8690630 [details] [diff] [review]
bug-1198576.v02.patch

Review of attachment 8690630 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! This patch removes unused codes to make our codes cleaner.

Comment 9

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cb1a4573838

Comment 10

[Benjamin Chen [:bechen]]

Attachment: bug-1198576.v02.patch

r=bwu
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5aa57955d857

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5223d6786b2b

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5223d6786b2b