1198744 - filters run on a different folder than selected

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[:aceman]

STR:
1.Select a folder other than Inbox
2.Use Tools->Filters
3.Observe the currently selected folder is shown in the "run selected filters on:"
4.Select a filter (I used "match all messages, add star")
5.Click "Run Now"

Expected result:
Messages in the currently visible folder filtered (in my case all starred).

Actual result:
Nothing happens. (If you use "Add star action" on Windows XP, be sure not to actually see bug 1198314).
But after further inspection, I noticed the filter got applied to another folder, in my case Inbox of the first account.

I marked this dataloss as depending on what the filter does, it may delete messages in another folder without the user noticing. Even if the messages get into Trash, the user may later empty it as he doesn't know valid messages are hiding there.

Potential regression from bug 878805, which touched the folder picker.

Comment 1

[Wayne Mery (:wsmwk)]

So this would only ever happen with Run Now?

Comment 2

[:aceman]

Yes, I think so. It is a bug in the filter list dialog. There should be no problem when filters are run automatically (on receive or send), or if run from the menu (run filters on folder).

Can anybody reproduce it?

Comment 3

[:aceman]

Alta88, can you please look at this?

Comment 4

[alta88]

Attachment: initRunFolder.patch

Comment 5

[alta88]

Attachment: initRunFolder.patch

disable Run button if no folder selected.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 8690416 [details] [diff] [review]
initRunFolder.patch

Review of attachment 8690416 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. r=mkmelin with the comment clarified.

::: mail/base/content/FilterListDialog.js
@@ +241,5 @@
>  
>     if (canFilterAfterTheFact) {
> +     // Get the first folder for this server. INBOX for IMAP and POP3 accounts
> +     // and 1st news group for news. Disable the button for Choose Folder, for
> +     // none of the above accounts.

don't know what this last line is supposed to mean.

Comment 7

[:aceman]

Comment on attachment 8690416 [details] [diff] [review]
initRunFolder.patch

Review of attachment 8690416 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, seems to work for me too. Somehow I saw the bug now (before the patch) only on a subfolder of Inbox.

Comment 8

[alta88]

Attachment: initRunFolder.patch

clarify comment.

Comment 9

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/d45abb4b289717f94a91e82800326ea294b4811a
Bug 1198744 - Filters run on a different folder than selected. r=mkmelin

Comment 10

[aleth [:aleth]]

Looks to me like this affects esr38 and everything newer? Please mark for uplift if so.

Comment 11

[alta88]

Comment on attachment 8691370 [details] [diff] [review]
initRunFolder.patch

Low risk uplift, to ensure folderpane selected folder is set in Filterlist dialog on open.

Comment 12

[Kent James (:rkent)]

Comment on attachment 8691370 [details] [diff] [review]
initRunFolder.patch

I've been asked to mend my profligate ways and only push really urgent things to comm-esr38. But on the small chance that I relapse and want to merge it, it needs to go through a beta cycle first. Let's try to get it in.

http://hg.mozilla.org/releases/comm-aurora/rev/3f9bc9fae33f
http://hg.mozilla.org/releases/comm-beta/rev/db4f54bf946b

Comment 13

[Kent James (:rkent)]

Because of the missing beta 43, this patch did not get tested in a beta. I am reluctant to uplift to esr38 without at least a beta cycle. Any objections to waiting and considering again for 38.6?

Comment 14

[Kent James (:rkent)]

Comment on attachment 8691370 [details] [diff] [review]
initRunFolder.patch

https://hg.mozilla.org/releases/comm-esr38/rev/e839c236d499

I looked this over, and it seems low risk to me, and the effects of running a filter on the wrong folder can be pretty bad.