1198828 - Superfluous bind(this) in network-panel.js

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[:Gijs (he/him)]

https://dxr.mozilla.org/mozilla-central/rev/f61c3cc0eb8b7533818e7379ccc063b611015d9d/browser/devtools/webconsole/network-panel.js#327

        a.addEventListener("mousedown", this._longStringClick.bind(this, aItem));

|this| is the same |this| that function got bound to in the panel's constructor (because of the arrow function in which this addEventListener call happens:


function NetworkPanel(aParent, aHttpActivity, aWebConsoleFrame)
{
...
  this._longStringClick = this._longStringClick.bind(this);

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Reviewboard's hg is down, so splinter it is. (Patrick, please forward as appropriate...)

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dcb1e80534cf

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dcb1e80534cf