1198917 - google protobuf architecture ifdefs inconsistency

Status: NEW

(Core :: General, defect)

Description

[Martin Husemann]

Attachment: force GOOGLE_PROTOBUF_ARCH_64_BIT on sparc 64 bit builds if not on solaris

google protobufs atomics in general use GOOGLE_PROTOBUF_ARCH_64_BIT to test for a 64bit build, but sometimes _LP64 is used. This leads to inconsistencies and build failures - noticed on NetBSD/sparc64 but probably all non-solaris sparc64 builds are affected.

Simple patch attached, but I have no idea how this upstream is handled.

Comment 1

[Martin Husemann]

I found the github upstream tracker and created an issue there as well: https://github.com/google/protobuf/issues/763

Comment 2

[Martin Husemann]

This has been fixed (slightly differently) upstream now. Importing a newer protobuf variant would fix the issue.