1198981 - SuperSearch UI doesn't validate date parameters

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

Someone did this search https://crash-stats.allizom.org/search/results/?product=Firefox&version=ALL%3AALL&range_value=2&range_unit=weeks&date=10%2F18%2F2014+05%3A00%3A00&query_search=signature&query_type=contains&query=libavcodec.so&reason=&release_channels=&build_id=&process_type=any&hang_type=any

Basically, the critical mistake is: date=10/18/2014+05:00:00  (unquoted)

That's not a valid ISO date. And it thus shouldn't have been allowed through.

Comment 2

[Peter Bengtsson [:peterbe]]

I tried to reproduce this using the branch mentioned in the PR in https://bugzilla.mozilla.org/show_bug.cgi?id=1264960 and now you get a pleasant 400 Bad Request error that explains my input mistake. 

Once 1264960 let's double-check that all date inputs to SuperSearch, that are not valid, trigger a pleasant error instead of an internal server error.

Comment 3

[Peter Bengtsson [:peterbe]]

We fixed this (in some other bug) when we wrapped the calling of the implementation class's get/post with a try:except with BadArgumentError. 

The same URL as mentioned in the description now throws a 400 Bad Request.