1199023 - remove scrolling="no" from mochitest-chrome harness iframe

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Timothy Nikkel (:tnikkel)]

scrolling="no" makes the iframe unlike almost every iframe ever used in practice. In particular it's different from the iframe we use to house every content document.

http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/harness.xul#85

I chased the history on this. It originates with the original landing of the mochitest framework, and the landing gives no justification or hint as to why.

See bug 1177018, comment 3 for where this difference came up in practice.

Comment 1

[(not currently active) Ted Mielczarek]

Mochitest has a lot of historical cruft. Unfortunately most of the time trying to remove it causes tests to fail. If this doesn't cause tests to fail then feel free to remove it!

Comment 2

[Timothy Nikkel (:tnikkel)]

I think I did a try run and it was mostly green, but my memory is a little fuzzy on it.

Comment 3

[Timothy Nikkel (:tnikkel)]

Looks like only one failure on linux64:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c45dfcbcfd9

in image/test/mochitest/test_svg_animatedGIF.html

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Bug 1261158 moved the failing test (image/test/mochitest/test_svg_animatedGIF.html) to regular mochitest, which seems to have made this pass.

Either way, I think the underlying bug with that test failing was bug 1223747 and/or bug 1223751 (they are interrelated). These bugs coincidentally landed yesterday too.

try run showing it green

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cde2c5fe2a16

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7d0413af62b

Comment 6

[Timothy Nikkel (:tnikkel)]

(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> Looks like only one failure on linux64:
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c45dfcbcfd9
> 
> in image/test/mochitest/test_svg_animatedGIF.html

Because I just had to know, this is bug 1263472.

Comment 7

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8803d34bd9f8278b62c542e0ec5446148ce08fe7

backed out for test failures on mac, guess I didn't go a mac try push.

Comment 8

[Timothy Nikkel (:tnikkel)]

Failure was


3672 INFO TEST-UNEXPECTED-FAIL | widget/tests/test_native_key_bindings_mac.html | editable: Incorrect anchor offset - got 139, expected 144
3673 INFO TEST-UNEXPECTED-FAIL | widget/tests/test_native_key_bindings_mac.html | editable: Incorrect focus offset - got 139, expected 144 

otherwise appeared to be green.

Comment 9

[Timothy Nikkel (:tnikkel)]

Attachment: fix test

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b71d47c19e79
https://hg.mozilla.org/integration/mozilla-inbound/rev/80051b8b7bf4

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b71d47c19e79
https://hg.mozilla.org/mozilla-central/rev/80051b8b7bf4