Closed Bug 1199023 Opened 5 years ago Closed 4 years ago

remove scrolling="no" from mochitest-chrome harness iframe

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(2 files)

scrolling="no" makes the iframe unlike almost every iframe ever used in practice. In particular it's different from the iframe we use to house every content document.

http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/harness.xul#85

I chased the history on this. It originates with the original landing of the mochitest framework, and the landing gives no justification or hint as to why.

See bug 1177018, comment 3 for where this difference came up in practice.
Mochitest has a lot of historical cruft. Unfortunately most of the time trying to remove it causes tests to fail. If this doesn't cause tests to fail then feel free to remove it!
I think I did a try run and it was mostly green, but my memory is a little fuzzy on it.
Looks like only one failure on linux64:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c45dfcbcfd9

in image/test/mochitest/test_svg_animatedGIF.html
Attached patch patchSplinter Review
Bug 1261158 moved the failing test (image/test/mochitest/test_svg_animatedGIF.html) to regular mochitest, which seems to have made this pass.

Either way, I think the underlying bug with that test failing was bug 1223747 and/or bug 1223751 (they are interrelated). These bugs coincidentally landed yesterday too.

try run showing it green

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cde2c5fe2a16
Attachment #8738265 - Flags: review?(ted)
Summary: remove scrolling="no" from mochitest harness iframe → remove scrolling="no" from mochitest-chrome harness iframe
Attachment #8738265 - Flags: review?(ted) → review+
(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> Looks like only one failure on linux64:
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c45dfcbcfd9
> 
> in image/test/mochitest/test_svg_animatedGIF.html

Because I just had to know, this is bug 1263472.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8803d34bd9f8278b62c542e0ec5446148ce08fe7

backed out for test failures on mac, guess I didn't go a mac try push.
Failure was


3672 INFO TEST-UNEXPECTED-FAIL | widget/tests/test_native_key_bindings_mac.html | editable: Incorrect anchor offset - got 139, expected 144
3673 INFO TEST-UNEXPECTED-FAIL | widget/tests/test_native_key_bindings_mac.html | editable: Incorrect focus offset - got 139, expected 144 

otherwise appeared to be green.
Attached patch fix testSplinter Review
Attachment #8740249 - Flags: review?(jryans)
https://hg.mozilla.org/mozilla-central/rev/b71d47c19e79
https://hg.mozilla.org/mozilla-central/rev/80051b8b7bf4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.