Open Bug 1199088 Opened 4 years ago Updated 8 months ago

add storage to sessions

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set

Tracking

()

People

(Reporter: glob, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

bugzilla lacks simple session storage to carry state between requests.
adding this simplifies a few features.
Attached patch 1199088_1.patch (obsolete) — Splinter Review
- adds session_data table for name/value paris
- adds Bugzilla::User::SessionData

as it isn't used yet, here's some sample code for testing:

$user->session->data->set('example', 'hello world');
my $t = $user->session->data->get('example');
$user->session->data->delete('example');
Attachment #8655987 - Flags: review?(dylan)
Attached patch 1199088_2.patchSplinter Review
i realised last night that enabling memcached in B::User::Session right now would be problematic, as we don't invalidate those entries when sessions expire.

rather than introduce more scope creep this revision leaves memcached disabled for those objects.
Attachment #8655987 - Attachment is obsolete: true
Attachment #8655987 - Flags: review?(dylan)
Attachment #8656420 - Flags: review?(dylan)
Comment on attachment 8656420 [details] [diff] [review]
1199088_2.patch

Review of attachment 8656420 [details] [diff] [review]:
-----------------------------------------------------------------

this solves some problems, but I realize using logincookies as the "session" doesn't help for un-auth'd users. There are some use cases for un-auth'd sessions.

Clearing review per IRC.
Attachment #8656420 - Flags: review?(dylan)
for bug 1199087 it's simpler to bind the required data to tokens rather than sessions, removing from blocker.

this is still useful to do, but is now a lower priority.
No longer blocks: 1199087
Assignee: glob → nobody
No longer blocks: 1199092
Type: defect → enhancement
You need to log in before you can comment on or make changes to this bug.