Status

()

bugzilla.mozilla.org
General
3 years ago
2 years ago

People

(Reporter: glob, Unassigned)

Tracking

(Blocks: 1 bug)

Production

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
bugzilla lacks simple session storage to carry state between requests.
adding this simplifies a few features.
(Reporter)

Updated

3 years ago
Blocks: 1199087
(Reporter)

Updated

3 years ago
Blocks: 1199092
(Reporter)

Comment 1

3 years ago
Created attachment 8655987 [details] [diff] [review]
1199088_1.patch

- adds session_data table for name/value paris
- adds Bugzilla::User::SessionData

as it isn't used yet, here's some sample code for testing:

$user->session->data->set('example', 'hello world');
my $t = $user->session->data->get('example');
$user->session->data->delete('example');
Attachment #8655987 - Flags: review?(dylan)
(Reporter)

Comment 2

3 years ago
Created attachment 8656420 [details] [diff] [review]
1199088_2.patch

i realised last night that enabling memcached in B::User::Session right now would be problematic, as we don't invalidate those entries when sessions expire.

rather than introduce more scope creep this revision leaves memcached disabled for those objects.
Attachment #8655987 - Attachment is obsolete: true
Attachment #8655987 - Flags: review?(dylan)
Attachment #8656420 - Flags: review?(dylan)
Comment on attachment 8656420 [details] [diff] [review]
1199088_2.patch

Review of attachment 8656420 [details] [diff] [review]:
-----------------------------------------------------------------

this solves some problems, but I realize using logincookies as the "session" doesn't help for un-auth'd users. There are some use cases for un-auth'd sessions.

Clearing review per IRC.
Attachment #8656420 - Flags: review?(dylan)
(Reporter)

Comment 4

3 years ago
for bug 1199087 it's simpler to bind the required data to tokens rather than sessions, removing from blocker.

this is still useful to do, but is now a lower priority.
No longer blocks: 1199087
(Reporter)

Updated

2 years ago
Assignee: glob → nobody
No longer blocks: 1199092
(Reporter)

Updated

2 years ago
Blocks: 1199092
You need to log in before you can comment on or make changes to this bug.