Closed Bug 1199155 Opened 4 years ago Closed 4 years ago

Create a subclass of MediaSink to wrap DecodedStream for audio/video rendering

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Blocks: 1199098
Priority: -- → P2
Blocks: 1199562
Bug 1199155. Part 1 - move dom/media/DecodedStream.* to dom/media/mediasink/ and implement the interface of MediaSink.
Attachment #8657685 - Flags: review?(roc)
Bug 1199155. Part 2 - fix includes and forward declarations.
Attachment #8657686 - Flags: review?(roc)
Bug 1199155. Part 3 - rename mDecodedStream to mStreamSink.
Attachment #8657687 - Flags: review?(roc)
Comment on attachment 8657685 [details]
MozReview Request: Bug 1199155. Part 1 - move dom/media/DecodedStream.* to dom/media/mediasink/ and implement the interface of MediaSink.

https://reviewboard.mozilla.org/r/18409/#review16473

::: dom/media/mediasink/DecodedStream.cpp:593
(Diff revision 1)
> +  mParams.playbackRate = aPlaybackRate;

The fields of mParams should be mPlaybackRate etc
Attachment #8657685 - Flags: review?(roc) → review+
Comment on attachment 8657686 [details]
MozReview Request: Bug 1199155. Part 2 - fix includes and forward declarations.

https://reviewboard.mozilla.org/r/18411/#review16475
Attachment #8657686 - Flags: review?(roc) → review+
https://reviewboard.mozilla.org/r/18409/#review16473

> The fields of mParams should be mPlaybackRate etc

Since the change involes several files, I will file another bug to fix the coding style. Thanks for the review!
Blocks: 1202533
https://hg.mozilla.org/mozilla-central/rev/2b98b13cfe16
https://hg.mozilla.org/mozilla-central/rev/402d77e444c0
https://hg.mozilla.org/mozilla-central/rev/ea42cfe74cf3
Assignee: nobody → jwwang
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.