Hitting Ctrl-C for stopping firefox_ui_updates script does not sanely shutdown Firefox

RESOLVED WORKSFORME

Status

--
major
RESOLVED WORKSFORME
3 years ago
2 years ago

People

(Reporter: whimboo, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
I have seen this today during testing the script. Whenever you hit Ctrl-C while the tests are running, the mozharness script exists immediately and keeps the Firefox instance running. As a result follow-up tests cannot be run because the port for Marionette is still in use.

We have to make sure that we always shutdown the sanely.
(Reporter)

Comment 2

3 years ago
I think the problem here lays in mozprocess (ProcessHandler) which uses POpen to start and control processes. Sending the control character Ctrl+C will kill the started process without giving it the time to clean-up internally. If we could make sure that ProcessHandler can delay that a bit and tell the started process to shutdown and clean-up all would be fine. Lemme see if I can find something.
(Reporter)

Updated

3 years ago
Depends on: 1201871
(Reporter)

Comment 3

3 years ago
We are blocked on Marionette here. A ctrl-c in mozharness will cause a SIGTERM/SIGINT for the firefox-ui-update subprocess. That's not handled correctly.
(Reporter)

Updated

3 years ago
Blocks: 1209209
(Reporter)

Comment 4

3 years ago
It's actually not a hard-blocker but we should try to get this fixed. I pinged Ted via email again and hope to get a reply from him on the other bug soonish.
No longer blocks: 1197358, 1209209
Severity: normal → major
(Reporter)

Updated

2 years ago
Blocks: 1283906
(Reporter)

Comment 5

2 years ago
Maybe something has been changed in mozharness base scripts but the problem does no longer occur for me on my Linux and OS X machine. I would close this bug as WFM for now, and keep the option to reopen in case I see it again.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
(Reporter)

Updated

2 years ago
No longer blocks: 1283906
You need to log in before you can comment on or make changes to this bug.