Closed Bug 1199201 Opened 9 years ago Closed 9 years ago

WebIDE doesn't load correctly when using devtools.loader.srcdir

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file, 1 obsolete file)

Various modules don't load due to broken path in Loader.jsm mapping.
Attached patch patch v1 (obsolete) — Splinter Review
Most stuff seems to work, let see if that's enough.
Assignee: nobody → poirot.alex
Comment on attachment 8653471 [details] [diff] [review]
patch v1

I looked at all webide panel, and everything looks good with this.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c49ec1ab66d
Attachment #8653471 - Flags: review?(jryans)
Attached patch patch v2Splinter Review
Had to update loader test.
Attachment #8653471 - Attachment is obsolete: true
Attachment #8653471 - Flags: review?(jryans)
Attachment #8653563 - Flags: review+
Attachment #8653563 - Flags: review+ → review?(jryans)
Comment on attachment 8653563 [details] [diff] [review]
patch v2

Review of attachment 8653563 [details] [diff] [review]:
-----------------------------------------------------------------

I'm removing most of these soon as part of bug 912121, but it's fine to do this now.

I'll have to test my version to be sure WebIDE works there.
Attachment #8653563 - Flags: review?(jryans) → review+
https://hg.mozilla.org/mozilla-central/rev/e95bfd7d9d36
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: