1199202 - Fix handling of CLI options for firefox-ui-updates.py script

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As already mentioned over on bug 1197358 we should tweak the command line options to allow the following:

* If no update_verify_config has been specified we do not need to checkout the tools repository. Because of that we should not force the usage of --tools-tag if this config option has not been specified.

* If no absolute path for the install-path has been given, we have to enforce it. Otherwise we are passing an invalid path to mozinstall because of the changed CWD.

* --limit-locales causes an exception if not specified. It should define a default (0) and should be of type int.

Patch is upcoming shortly.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: CLI options fix

Armen, if your review is not enough please suggest whom I also have to ask for.

Comment 2

[Armen [:armenzg]]

Comment on attachment 8653473 [details] [diff] [review]
CLI options fix

Review of attachment 8653473 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! Feel free to land with DONTBUILD.

Comment 3

[Armen [:armenzg]]

or NPOTB (I think :D)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00fce13db0ea

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00fce13db0ea

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Armen, with this patch I broke the script for handling release tests due to the default value of -1 for limit locales. Right now no tests are getting run at all. Sorry! I'm going to fix that along with my patch on bug 1200368.