1199215 - Implement JS::ubi::Node::size for JS::Symbol referents

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

+++ This bug was initially created as a clone of Bug #1063257 +++

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Implement JS::ubi::Node::size for JS::Symbol referents

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8662646 [details] [diff] [review]
Implement JS::ubi::Node::size for JS::Symbol referents

Review of attachment 8662646 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Symbol.cpp
@@ +153,5 @@
>      return v.isSymbol() ? v.toSymbol() : v.toObject().as<SymbolObject>().unbox();
>  }
> +
> +
> +JS::ubi::Node::Size

Is there an extra blank line here?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba36f2cc953e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba36f2cc953e