If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Display keyboard shortcut when hovering over the filter input of network panel

NEW
Unassigned

Status

()

Firefox
Developer Tools: Netmonitor
--
enhancement
2 years ago
2 years ago

People

(Reporter: groovecoder, Unassigned)

Tracking

41 Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Lots of keyboard shortcuts available since I filed https://bugzilla.mozilla.org/show_bug.cgi?id=723134 - yay!!

The main one I'd like to see (added or documented somewhere I can easily discover it) is to focus to the filter input element after I've used Cmd+Opt+Q to get to the network panel.
I think this is a dupe: https://bugzilla.mozilla.org/show_bug.cgi?id=892229
For me on Mac, Cmd-F does not seem to do anything in the network panel.  It opens the Firefox find bar instead.

Maybe there's more to do?
(Reporter)

Comment 3

2 years ago
Both right. If I use Cmd-Opt-Q and then Cmd-F, it focuses into the filter box correctly. If I focus on the main browser window, it opens Firefox find bar. I'm fine with that - makes sense.

The main thing that would have helped me here is if hovering my mouse over the filter input would show a tool-tip with the keyboard shortcut. Changed the bug summary to match and marked as enhancement. Happy to have it prioritized however seems right for this feature request.

I may also take it upon myself to do this to make me learn how to submit dev tools patches? Should I assign the bug to myself?
Severity: normal → enhancement
Flags: needinfo?(jgriffiths)
Summary: Add (or display) keyboard shortcut to focus on the filter input of network panel → Display keyboard shortcut when hovering over the filter input of network panel
(In reply to Luke Crouch [:groovecoder] from comment #3)
...
> The main thing that would have helped me here is if hovering my mouse over
> the filter input would show a tool-tip with the keyboard shortcut. Changed
> the bug summary to match and marked as enhancement. Happy to have it
> prioritized however seems right for this feature request.

A fine point!

> I may also take it upon myself to do this to make me learn how to submit dev
> tools patches? Should I assign the bug to myself?

That would be awesome! It's not terribly hard, and you should ping Ryan on IRC so he can tell about our porject to make it even easier, very soon. The current process is documented here: https://wiki.mozilla.org/DevTools/GetInvolved
Flags: needinfo?(jgriffiths)
(In reply to Jeff Griffiths (:canuckistani) from comment #4)
> > I may also take it upon myself to do this to make me learn how to submit dev
> > tools patches? Should I assign the bug to myself?
> 
> That would be awesome! It's not terribly hard, and you should ping Ryan on
> IRC so he can tell about our porject to make it even easier, very soon. The
> current process is documented here:
> https://wiki.mozilla.org/DevTools/GetInvolved

We're aiming to improve DevTools contribution in multiple ways, like reorganizing the code, reload support for the tools, some kind of GitHub flow, etc.  But, that stuff is not here yet.

If you prefer using Git over Mercurial, you may like Will's new guide which uses Git:

https://developer.mozilla.org/en-US/docs/Tools/Contributing
(Reporter)

Comment 6

2 years ago
Attaching a patch where I'm trying this ...

I could also use a mentor for help me figure out how to add the platform-specific accel key string to the tooltip. Is there something like &sys.accel.label available to .xul files for that?

I notice that the Tools definitions use js-level logic to show "Cmd" vs. "Ctrl" for Mac vs. others. [1] Is that the only way to do it?

[1] https://github.com/mozilla/gecko-dev/blob/1763463649943208cc4572be60062fb11fe4361d/browser/devtools/definitions.js#L315-L318
(Reporter)

Comment 7

2 years ago
Created attachment 8658917 [details] [diff] [review]
adding tooltiptext to key in netmonitor.xul
You need to log in before you can comment on or make changes to this bug.