1199288 - rename mApplyUserSelectStyle to something more appropriate

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

As of bug 571294, that variable is also used to determine whether a selection event is triggered by a user or the document for the purposes of firing the `selectstart` event, which means that the variable's name is no longer really accurate.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Rename mApplyUserSelectStyle to mUserInitiated

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8664852 [details] [diff] [review]
Rename mApplyUserSelectStyle to mUserInitiated

mUserInitiated sounds a bit odd, but I don't really have much better ideas.
mUserInitiatedSelection is a bit more descriptive, but given that we're in
Selection already, perhaps that is repetitive.
So fine.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Yeah, I really don't like the name either... I just couldn't come up with a better one.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

I'm not sure why pulsebot didn't catch this, but I did push this patch to inbound a while ago: https://hg.mozilla.org/integration/mozilla-inbound/rev/ba9e4910ae21

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ba9e4910ae21