smoketest fail: TestPicker.test_picker_to_form_to_picker

RESOLVED FIXED

Status

Input Graveyard
Code Quality
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: willkg, Assigned: willkg)

Tracking

Details

(Whiteboard: p=1 s=input.2015q3)

(Assignee)

Description

3 years ago
edwin-input
Getting this in the smoketests:

------------------------------------------- pytest-mozwebqa --------------------------------------------
Failing URL: https://input.allizom.org/en-US/?q=firefox&date_end=2015-08-27&date_start=2015-02-28
_______________________________ TestPicker.test_picker_to_form_to_picker _______________________________

self = <tests.generic.test_picker.TestPicker object at 0x7f1fee8ca7d0>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x7f1fee87bc68>

    def test_picker_to_form_to_picker(self, mozwebqa):
        # Go to /feedback/, verify product picker page comes up, and
        # verify there are products on it
        picker_pg = PickerPage(mozwebqa)
        picker_pg.go_to_picker_page()
    
        # We can't guarantee which products are in the list or what
        # order they're in, so we do this goofy thing where we make
        # sure it's greater than one and hope "Firefox" is one of
        # them
        products = picker_pg.products
>       Assert.greater(len(products), 0)

tests/generic/test_picker.py:22: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <class 'unittestzero.Assert'>, first = 0, second = 0, msg = None

    @classmethod
    def greater(self, first, second, msg=None):
        """
            Asserts that first element is greater than the second element
    
            :Args:
             - First object to be tested
             - Second object to be tested
             - Message that will be printed if it fails
            """
    
>       assert first > second, msg
E       AssertionError: None

../../../.virtualenvs/inputqa/lib/python2.7/site-packages/unittestzero.py:216: AssertionError


I'm pretty sure it's because I restyled the product picker page and didn't update the smoketest.
Pretty sure this is an easy fix, so I'm estimating it at 1 point.

I'll grab it to fix tomorrow.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Whiteboard: p=1 s=input.2015q3
Landed in master: https://github.com/mozilla/fjord/commit/f51b72183595e0f0a38d6388a3ca63d4dbeb6228
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.