Closed Bug 1199354 Opened 4 years ago Closed 4 years ago

Update the Android and iOS download links on the Sync preferences pane

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 45
Iteration:
44.2 - Oct 19
Tracking Status
firefox44 --- verified
firefox45 --- verified

People

(Reporter: ckarlof, Assigned: markh)

References

Details

(Whiteboard: [fxsync])

Attachments

(2 files, 8 obsolete files)

Flags: firefox-backlog+
Whiteboard: [fxsync]
Duplicate of this bug: 1194508
Bug 1194508 was originally for adding the iOS solicitation to the Sync prefs pane. I've marked that as a duplicate of this.
Iteration: --- → 43.3 - Sep 21
Assignee: nobody → markh
This makes the requested changes. I'm unsure of the "attribution" for the iOS trademark, so I'll ping legal for help (it's complicated - Cisco owns that trademark!).

Flod, in the meantime, would you mind checking the sanity of this from a l10n perspective?
Attachment #8662761 - Flags: feedback?(francesco.lodolo)
Attached image ios-link-signedout.png (obsolete) —
How it looks in the "not signed in" state.
Comment on attachment 8662762 [details]
ios-link-signedout.png

Bryan, are you happy with this?
Attachment #8662762 - Flags: ui-review?(bbell)
Attached image ios-link-signedin.png (obsolete) —
How it looks when signed in.
Attachment #8662763 - Flags: ui-review?(bbell)
I opened bug 1205955 to request legal review of the use of the iOS trademark and attribution - I hope that's the right place :)
Comment on attachment 8662761 [details] [diff] [review]
0001-Bug-1199354-add-link-to-Firefox-for-iOS-and-fix-link.patch

Review of attachment 8662761 [details] [diff] [review]:
-----------------------------------------------------------------

Nits on comments, but the structure looks good.

::: browser/locales/en-US/chrome/browser/preferences/sync.dtd
@@ +89,5 @@
>  <!ENTITY signedOut.accountBox.create  "Create Account">
>  <!ENTITY signedOut.accountBox.signin  "Sign In">
>  
>  <!ENTITY signedIn.engines.label       "Sync across all devices">
>  

Given how complex this piece is becoming (I wish we could use .properties and one string), I'd put a comment explaining how the final string will look.

<!-- LOCALIZATION NOTE (mobilePromo.*): the following strings will be used to 
     create a single sentence with active links.
     The resulting sentence in English is: "Download Firefox for Android or 
     iOS to sync with your mobile device." -->

@@ +91,5 @@
>  
>  <!ENTITY signedIn.engines.label       "Sync across all devices">
>  
>  <!ENTITY mobilePromo.start            "Download Firefox for ">
> +<!-- LOCALIZATION NOTE (mobilePromo.androidLink): This is a link title that links to https://www.mozilla.org/firefox/android/?... -->

Editor fault (end of the line cut)?

I'd say "Used as text for a link to https://www.mozilla.org/firefox/android/"

@@ +96,3 @@
>  <!ENTITY mobilePromo.androidLink      "Android™">
> +
> +<!-- LOCALIZATION NOTE (mobilePromo.iOSBefore): This is text displayed between the mobilePromo.androidLink and the iOS icon -->

iOS icon -> mobilePromo.iOSLink

"This text is displayed between mobilePromo.androidLink and mobilePromo.iOSLink"

@@ +96,5 @@
>  <!ENTITY mobilePromo.androidLink      "Android™">
> +
> +<!-- LOCALIZATION NOTE (mobilePromo.iOSBefore): This is text displayed between the mobilePromo.androidLink and the iOS icon -->
> +<!ENTITY mobilePromo.iOSBefore         " or ">
> +<!-- LOCALIZATION NOTE (mobilePromo.iosLink): This is a link title that links to https://www.mozilla.org/firefox/ios/?... -->

Same as above: "Used as text for a link to https://www.mozilla.org/firefox/ios/"
Attachment #8662761 - Flags: feedback?(francesco.lodolo) → feedback+
Awesome, thanks very much, all feedback addressed - now to wait on legal...
Attachment #8662761 - Attachment is obsolete: true
The advice from legal is:

> We can't use the Apple logo so you'll have to remove that. You should also
> remove the TM from iOS and change the trademark attribution statement to: "IOS
> is a trademark or registered trademark of Cisco in the U.S. and other countries
> and is used by Apple under license."
New patch following advice from legal.
Attachment #8662775 - Attachment is obsolete: true
Attached image ios-link-signedin.png (obsolete) —
This is how it looks without the Apple logo. I'm a little concerned that without the logo users may not associate "iOS" with their apple device, so I'd think different wording might be appropriate. If you do come up with better wording that uses an Apple trademark (such as "Apple";), you should probably ask for further advice in bug 1205955 :(
Attachment #8662763 - Attachment is obsolete: true
Attachment #8662763 - Flags: ui-review?(bbell)
Attachment #8667631 - Flags: ui-review?(rfeeley)
Attached image ios-link-signedout.png (obsolete) —
For completeness, how it looks when signed out.
Attachment #8662762 - Attachment is obsolete: true
Attachment #8662762 - Flags: ui-review?(bbell)
Comment on attachment 8667631 [details]
ios-link-signedin.png

Oops, I think I meant to ask for ui-review from Bryan but I'll leave the request on Ryan too - first one to respond wins :)
Attachment #8667631 - Flags: ui-review?(bbell)
I have confirmation from Urmika in July that we can indeed use the Apple logo. A quick glance at both Dropbox and Spotify shows them using the logos this way in a very similar context without attribution. What has changed?
Flags: needinfo?(markh)
I've added that information to the legal bug and indicated we intend to move ahead using the logo. I'll give it a day or 2 then reinstate the earlier patch.
Flags: needinfo?(markh)
Assigning to Bill to help resolve this with Legal.
Assignee: markh → wmaggs
Iteration: 43.3 - Sep 21 → 44.2 - Oct 19
The meeting with Liz Compton included her review of sites (she named Youtube and several others) that showed that many companies are following the Apple iOS branding guidelines and so we have two choices: use the buttons for Android and iOS app stores; or follow the guidelines and use the product names, both choices linking to the download page in each store. It is worth pointing out that only Android allows download to device from a web page. 

It is true that these choices would lead to not using the robot logo, which Google allows. I'd like to know from Ryan F if the loss of this visually appealing item is a big one, and also which of the two options above (store logo button or product name in a link) is preferable.
> I'd like to know from Ryan F if the loss of this visually appealing item is a big one, and also which of the two options above (store logo button or product name in a link) is preferable.

Paging Ryan F.
Assignee: wmaggs → nobody
Flags: needinfo?(rfeeley)
Assignee: nobody → wmaggs
It is a big one and we have user testing to prove that users notice and act on the logos. We have legal clearance from Mika to use the logos as other properties do. Please forge ahead.
Flags: needinfo?(rfeeley)
continuing to work with Legal - discussion escalated.
Decision for till legal decides on logo: 

Sync to your mobile device. Download __Firefox for Android__ or __Firefox for iOS__.

*note: no android logo and '__' means it's a link.
Attached image ios-link-no-logos.png
Here's a version with no images and no attribution. I felt the separators looked a little strange with all that removed, so I moved these links into the "device" section - IMO it makes sense (it's saying both "name this device" and "get it for your other devices") and it looks a little better.

Ryan, you OK with that?
Attachment #8667630 - Attachment is obsolete: true
Attachment #8667631 - Attachment is obsolete: true
Attachment #8667632 - Attachment is obsolete: true
Attachment #8667631 - Flags: ui-review?(rfeeley)
Attachment #8667631 - Flags: ui-review?(bbell)
Attachment #8680963 - Flags: ui-review?(rfeeley)
Hi Drew,
  We've had a few issues with legal giving the OK for using the Apple logo, and while we hope to eventually get it, we decided to remove the Android logo in the meantime to make things consistent.

We also changed the links to refer to our product names (Firefox for Android and Firefox for iOS), so we removed the attribution for Android and haven't added one for iOS. This is consistent with the landing page for those links, where those terms are also used without attribution.

We'd love to get this in 44.

(Re the screenshot - I've tweaked it so the space before the trailing period is no longer there.)
Attachment #8680977 - Flags: review?(adw)
Attachment #8680977 - Flags: review?(adw) → review+
Comment on attachment 8680963 [details]
ios-link-no-logos.png

Ryan approved this over IRC.
Attachment #8680963 - Flags: ui-review?(rfeeley) → ui-review+
Comment on attachment 8680977 [details] [diff] [review]
0001-Bug-1199354-add-link-to-Firefox-for-iOS-and-fix-link.patch

Review of attachment 8680977 [details] [diff] [review]:
-----------------------------------------------------------------

Please back-out this, or fix it before it merges to mozilla-central

You basically need to change all the string IDs, you can't update an existing string like this.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Attachment #8680977 - Flags: feedback-
Flags: needinfo?(markh)
Sorry about that, I should have known better. Backed out in https://hg.mozilla.org/integration/fx-team/rev/a7b87003fc4f
Flags: needinfo?(markh)
As relanded

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: They wont be informed of the great opportunity to download Firefox for their mobile device on the Sync prefs page! :)
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: Limited to Sync prefs page, and just adds a new link
[String/UUID change made/needed]: New promo strings, missed the unexpected merge.
Assignee: wmaggs → markh
Attachment #8680977 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8681192 - Flags: review+
Attachment #8681192 - Flags: approval-mozilla-aurora?
Note from l10n: this seems like a good bug to take. The last thing I'd want is legal pushing to fix things later in the trains.
https://hg.mozilla.org/mozilla-central/rev/d924e89139c2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
(In reply to Carsten Book [:Tomcat] from comment #32)
> https://hg.mozilla.org/mozilla-central/rev/d924e89139c2

That was the backout; reopening until the relanded version merges.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/fc898522b3fb
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Mark, is this ready to land on Aurora? I noticed comment 33 talks about a back out and therefore wanted to confirm with you before approving this patch.
Flags: needinfo?(markh)
Ryan, the guidance we received from Nick N. is that from a product perspective he's fine with the approach of using the logos as long as we can instrument this benefit, so that we can make more informed decisions here in the future.

Ryan, is there a previous A/B test which demonstrates this benefit? If not, we'll need to design a new one for this situation if we want to drive this forward.
Depends on: 1221294
I filed Bug 1221294 as a followup here to add the logos. If we add them, we'll need to ship them with an A/B test to evaluate their benefit.
(In reply to Ritu Kothari (:ritu) from comment #35)
> Mark, is this ready to land on Aurora? I noticed comment 33 talks about a
> back out and therefore wanted to confirm with you before approving this
> patch.

Yes, please uplift the relanded patch, https://hg.mozilla.org/mozilla-central/rev/fc898522b3fb
Flags: needinfo?(markh)
Given that we are 2 full days past string freeze, and we already made a mess with it, do we really need to uplift at this point?

If legal is fine with having logos (I assume it wasn't, hence my previous comment), and we don't risk to make last minute changes to pull them, my suggestion would be to leave this on mozilla-central and let the changes ride the train (it seems there are going to be more any way).
Comment on attachment 8681192 [details] [diff] [review]
0001-Bug-1199354-add-link-to-Firefox-for-iOS-and-fix-link.patch

Approved for uplift to Aurora given that this is still early in the Aurora cycle. I have pinged Flod as well to know this makes sense.
Attachment #8681192 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Ritu Kothari (:ritu) from comment #41)
> Approved for uplift to Aurora given that this is still early in the Aurora
> cycle. I have pinged Flod as well to know this makes sense.

I guess it's OK. Comment 39 was based on the assumption that we already had a reference to iOS, while we don't in Aurora.
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OS X 10.9.5 using Nightyl 45.0a1 (buildID: 20151120030227 - for Windows and buildID: 20151122030230 - for Mac and Ubuntu) and latest Aurora 44.0a2 (buildID: 20151122004109).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.