1199374 - Lightweight themes make it look like toolbars have greater height in normal window mode

Status: RESOLVED DUPLICATE of bug 1111138

(Firefox :: Theme, defect)

Description

[arni2033]

Attachment: #navigator-toolbox changing height.webm

STR:   (Win7_64bit, Nightly 43.0a1 32bit   ID 20150827030213, new profile)
1. Switch Firefox window to "normal" mode, e.g. dock to left side of screen
2. Enter Customization mode
3. Click "Themes", hover mouse over any lightweight theme

Result:       After Step 3 the height of #navigator-toolbox increased
Expectations: #navigator-toolbox should have same width with default and lightweight themes

Fx 31 if unaffected, 32 is affected. Don't know about ESR31.

Comment 1

[:Gijs (out for now; he/him)]

I expect this is caused by the top border we set on glass windows for lightweight themes.

However, those are on the #browser-panel... how sure are you the toolbox itself is changing height here, rather than it looking that way because the container (#browser-panel) gets a border?

Comment 2

[arni2033]

I'm not sure at all, I just described the symptoms, didn't actually debug this.
Please edit the title if needed, because sometimes I can't describe simple thing in English.
> Result:       Looks like after Step 3 the height of toolbars increased
> Expectations: Toolbars should have same width (visually) with default and lightweight themes

Comment 3

[arni2033]

I'm not sure at all, I just described the symptoms, didn't actually debug this.
Please edit the title if needed, because sometimes I can't describe simple thing in English.
> Result:       Looks like after Step 3 the height of toolbars increased
> Expectations: Toolbars should have same *height(visually) with default and lightweight themes

Comment 4

[:Gijs (out for now; he/him)]

(In reply to arni2033 from comment #3)
> I'm not sure at all, I just described the symptoms, didn't actually debug
> this.
> Please edit the title if needed, because sometimes I can't describe simple
> thing in English.

That's fine, I was just trying to clarify. I can see the problem, I was just wondering if my diagnosis of it was wrong because you specifically called out #navigator-toolbox

I've confirmed that this is due to the top border on #browser-panel.

Comment 5

[:Gijs (out for now; he/him)]

Just realized this is a dupe of 1111138 which I'm mentoring (and have been for a while). Oops!