1199394 - [b2g] Scrollbar track in Shadow DOM is white

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Wilson Page [:wilsonpage]]

Attachment: shadow-dom-scrollbar.png

ACTUAL: Scrollbar tracks in shadow-dom are white
EXPECTED: Should appear same as normal scrollbar tracks (transparent)

Comment 1

[William Chen [:wchen]]

Attachment: Update b2g scrollbar style to apply on all scrollbars.

The issue here is that a couple style selectors for b2g scrollbars looks like this:

html xul|scrollbar { ... }

This doesn't work for scrollbars in the shadow DOM because it's in a disconnected subtree from the document tree.

viven: Is there a reason these selectors require the html ancestor? The other selectors in the file don't seem to have this requirement and it should be faster without it.

Comment 2

[vnicolas]

Comment on attachment 8656292 [details] [diff] [review]
Update b2g scrollbar style to apply on all scrollbars.

Review of attachment 8656292 [details] [diff] [review]:
-----------------------------------------------------------------

IIRC the reason why the scrollbars are prefixed with |html| is because years ago I made those CSS rules for Fennec (the xul version).
In there the root document was a XUL document with custom scrollbars and it was not supposed to be affected by those rules (which were inserted into the document by the platform).

Since b2g does not have any XUL document it seems safe to me to remove the |html| constraint.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5899ac3e7447

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5899ac3e7447