Name for carrier / operator is not consistent

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Irina Sandu, Assigned: Louie Lu, Mentored)

Tracking

({foxfood})

unspecified
foxfood

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [good first bug][mentor-lang=zh][bzlite][lang=js])

Attachments

(7 attachments, 1 obsolete attachment)

(Reporter)

Description

2 years ago
User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

We are using 2 different names for the same thing in the Cellular Settings menu. It's Carrier at the top and Network Operator further down. Let's be consistent. Network operator is probably a more universal term than carrier.
(Reporter)

Comment 1

2 years ago
Created attachment 8653748 [details]
system-b2g-application.ini
(Reporter)

Comment 2

2 years ago
Created attachment 8653749 [details]
dev-log-main.log
(Reporter)

Comment 3

2 years ago
Created attachment 8653751 [details]
properties.log
(Reporter)

Comment 4

2 years ago
Created attachment 8653752 [details]
screenshot.png
QA Whiteboard: [foxfood-triage]
Component: Gaia::Feedback → Gaia::Settings
Flags: needinfo?(pdolanjski)
[Tracking Requested - why for this release]:

Let's stick with 'operator' which is the most universally accepted name.  I suggest changing carrier to operator.
tracking-b2g: --- → backlog
Flags: needinfo?(pdolanjski)

Updated

2 years ago
Mentor: gasolin@mozilla.com
Whiteboard: [bzlite] → [good first bug][mentor-lang=zh][bzlite]

Comment 6

2 years ago
@harly could you help picking a proper name here?
Flags: needinfo?(hhsu)

Comment 7

2 years ago
ni @matej for wording as well
Flags: needinfo?(matej)

Comment 8

2 years ago
(In reply to Fred Lin [:gasolin] from comment #7)
> ni @matej for wording as well

+1 to "Operator"
Flags: needinfo?(matej)

Updated

2 years ago
Whiteboard: [good first bug][mentor-lang=zh][bzlite] → [good first bug][mentor-lang=zh][bzlite][lang=js]

Comment 9

2 years ago
I am fine with changing "Carrier" to "Operator". Thanks

Comment 10

2 years ago
So this issue will change strings in `Settings > Cellular & Data` panel:

"Carrier" to "Operator" 

and

"Network Operator" to "Operator"
Flags: needinfo?(hhsu)
(Assignee)

Comment 11

2 years ago
Hello, I like to take this bug, 
can you assigned to me?

And a question, how can I test `Settings > Cellular` in web IDE that I didn't have a real device for SIM card?

thanks.

Comment 12

2 years ago
Louie, thanks for interesting in take this issue. 

It will be more tricky to fix this issue when you don't have a device, so I suggest you start from another issue :/ 

Hope we can fix that contribution issue soon.
Created attachment 8655501 [details] [review]
[gaia] grapherd:callular-fix > mozilla-b2g:master
(Assignee)

Comment 14

2 years ago
Created attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties
Attachment #8655503 - Flags: review?(gasolin)

Updated

2 years ago
Assignee: nobody → grapherd

Comment 15

2 years ago
Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

Thanks for providing the patch!

For strings we have to rename the identifier to the other, so the automation tool can scan the difference and provide the changed strings to l10n team.

Please address the comment in github and set review again.
Attachment #8655503 - Flags: review?(gasolin)
(Assignee)

Comment 16

2 years ago
Created attachment 8657406 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

Change l10n identifier in carrier.html and carrier_detail.html to suggestion, too.

If the name of `Carrier` change to `Operator`, shall the element name and other carrier change to operator too?

e.g. 
carrier.html -> operator.html
<element name="carrier" ...> -> <element name="operator" ...>
<ul class="carrier-info" ...> -> <ul class="operator-info" ...>
Flags: needinfo?(gasolin)
Attachment #8657406 - Flags: review?(gasolin)
(Assignee)

Comment 17

2 years ago
Comment on attachment 8657406 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

>https://github.com/mozilla-b2g/gaia/pull/31634
Attachment #8657406 - Attachment is obsolete: true
Attachment #8657406 - Flags: review?(gasolin)

Comment 18

2 years ago
I have no strong opinion about change the naming here. You could change it or left it as you prefer.
Flags: needinfo?(gasolin)
(Assignee)

Updated

2 years ago
Attachment #8655503 - Flags: review?(gasolin)

Comment 19

2 years ago
Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

Thanks for providing pull request, 

There's a string that use `networkOperator` as value, please replace it as well and set review again.
Attachment #8655503 - Flags: review?(gasolin)

Comment 20

2 years ago
louie are you stilll interesting on solving this one? Or I can take care of it as well.
Flags: needinfo?(grapherd)
(Assignee)

Comment 21

2 years ago
Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

>https://github.com/mozilla-b2g/gaia/pull/31634
Flags: needinfo?(grapherd)
Attachment #8655503 - Flags: review?(gasolin)

Comment 22

2 years ago
Thanks for update! For quick review it looks fine to me.

Though I got sick today and will get a test device tomorrow to check if everything works fine on real device.
Created attachment 8665738 [details] [review]
[gaia] gasolin:callular-fix > mozilla-b2g:master

Comment 24

2 years ago
Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

It looks fine to me, though there are some missing titles which are hard to find when you don't have device on hand. So I'll help add the rest.

Thank you Louie!
Attachment #8655503 - Flags: review?(gasolin) → review+

Comment 25

2 years ago
merged https://github.com/mozilla-b2g/gaia/commit/77dc0976a3834016df50a6eb767a4f5a135d3852

thanks!
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Please, for the future keep (In reply to Fred Lin [:gasolin] from comment #15)
> For strings we have to rename the identifier to the other, so the automation
> tool can scan the difference and provide the changed strings to l10n team.

Exactly, but you still changed 2 strings without using new IDs: availableOperators, operator-turnAutoSelectOff.

Any chance for a quick follow-up?
Flags: needinfo?(gasolin)

Comment 27

2 years ago
thanks for address the issue

merged https://github.com/mozilla-b2g/gaia/commit/33e8cfe0bf5f32d2ce860086d52a4a9534643ed7
Flags: needinfo?(gasolin)
You need to log in before you can comment on or make changes to this bug.