1199485 - File bugs automatically when submitting reviews

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

It would be awesome if MozReview could file bugs automatically when pushing commits for review. It would be even more awesome if commit messages were rewritten to reflect the created bug.

Filing bugs automatically would enable people to scratch itches while working on other work. If they find something weird, they can just `hg commit` + `hg push -c . review` which will create a new bug and submit a review and they can continue working on their original task.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: move some validation to before pushing (bug 1199485); r?smacleod

mozreview: move some validation to before pushing (bug 1199485); r?smacleod

Previously, we pushed to the review repo then moved on to submitting a
review. Validation of the review "environment" occurred during the
latter part, after pushing. This wastes people's time and prevents us
from doing more advanced things before push (such as rewrite commit
messages to reflect just-in-time created bugs).

This commit moves Bugzilla credential checking and review identifier
checking from post push pre review to pre push.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: advertise moz.build repo and bug encoding (bug 1199485); r?smacleod

mozreview: advertise moz.build repository from Mercurial server (bug 1199485); r?smacleod

Clients will use this to query the moz.build info (if necessary) to auto
file bugs, assign reviewers, etc. Currently, we do nothing except
advertise this URL.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8653791 [details]
MozReview Request: mozreview: move some validation to before pushing (bug 1199485); r?smacleod

mozreview: move some validation to before pushing (bug 1199485); r?smacleod

Previously, we pushed to the review repo then moved on to submitting a
review. Validation of the review "environment" occurred during the
latter part, after pushing. This wastes people's time and prevents us
from doing more advanced things before push (such as rewrite commit
messages to reflect just-in-time created bugs).

This commit moves Bugzilla credential checking and review identifier
checking from post push pre review to pre push.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8653792 [details]
MozReview Request: mozreview: advertise moz.build repo and bug encoding (bug 1199485); r?smacleod

mozreview: advertise moz.build repo and bug encoding (bug 1199485); r?smacleod

This is the start of a feature to enable just-in-time filing of bugs
at review submission time. In order to support that feature, clients
need a way to figure out which bug component to file a bug in. This
will be done by querying the moz.build files metadata web service
that runs on hg.mozilla.org.

Different repositories have different conventions for how they "encode"
bug references in commit messages. In order for clients to rewrite
commit messages, they need to know what style to use. We expose the
per-repo preference for bug reference "encoding" as a capability on the
server so clients can apply the proper syntax before submitting results
to the server.

Yes, this does mean that rewriting happens client side. bundle2 does
enable the Mercurial server to perform rewriting server side and to
"push back" the rewritten changesets to the client. However, bundle2
is not everywhere yet and the push back feature is still young. So,
despite the advantages of server-side rewriting (notably the ability to
upgrade the code without client cooperation), we opt to use
client-side rewriting for the time being.

Comment 5

[Gregory Szorc [:gps]]

Attachment: MozReview Request: ansible/docker-hg-reviewboard: script to set repo properties (bug 1199485); r?smacleod

ansible/docker-hg-reviewboard: script to set repo properties (bug 1199485); r?smacleod

We need the ability to change repo options on hgrb test servers. This
script could be more generic, but it serves the immediate need at hand,
which is to set the repository upstream and bug encoding format.

Comment 6

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: only search for bugs in commit summary line (bug 1199485); r?smacleod

mozreview: only search for bugs in commit summary line (bug 1199485); r?smacleod

Previously, we found bug references anywhere in the commit message.
Now, we only look at the first line. This is to enable bug-less commits
that happen to reference another bug from wrongly being attributed to
the older bug.

Comment 7

[Gregory Szorc [:gps]]

Attachment: MozReview Request: INCOMPLETE mozreview: create bugs during push

INCOMPLETE mozreview: create bugs during push

Comment 8

[Gregory Szorc [:gps]]

I'm not actively working on this, sadly.

Comment 10

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.