Closed
Bug 1199566
Opened 9 years ago
Closed 9 years ago
WebIDE: rename validator.wrongManifestFileName to reflect new string content
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: flod, Assigned: callahad)
References
Details
Attachments
(1 file)
http://hg.mozilla.org/mozilla-central/diff/64e74cd8eabc/browser/locales/en-US/chrome/browser/devtools/app-manager.properties -validator.wrongManifestFileName=Packaged apps require a manifest file that can only be named 'manifest.webapp' at project root folder +validator.wrongManifestFileName=A manifest file is required at project root folder, named either 'manifest.webapp' for packaged apps or 'manifest.json' for addons. This kind of changes require a new string ID. https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Reporter | ||
Comment 1•9 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #0) > +validator.wrongManifestFileName=A manifest file is required at project root > folder, named either 'manifest.webapp' for packaged apps or 'manifest.json' > for addons. Also note that addon is not the spelling used in Firefox, that would be add-on.
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1199566: Rename WebIDE validator string to reflect new content
Attachment #8654507 -
Flags: review?(poirot.alex)
Comment on attachment 8654507 [details] MozReview Request: Bug 1199566: Rename WebIDE validator string to reflect new content MozReview won't let me login right now, but it looks good to me. Thank you for fixing this up!
Attachment #8654507 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8654507 [details] MozReview Request: Bug 1199566: Rename WebIDE validator string to reflect new content https://reviewboard.mozilla.org/r/17711/#review15831 Got an r+ from :jyrans
Attachment #8654507 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
...I need to re-read how MozReview works. Anywho, try is running at https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbd432407968 On PTO this week, would appreciate a checkin-needed from someone on CC, provided there aren't any surprises from try.
Updated•9 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/687508df1763
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•