1199574 - Add --workspace CLI option as configurable location for all temporary data

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As of now we are creating temporary data in the /tmp folder which is not that good in conjunction with running the tests in our Jenkins CI. Reason is that this is outside of the Jenkins workspace and cannot be controlled and cleaned-up easily in case of failures in the harness. There should be a way to limit the creation of temporary data to a specific folder. By default this will still be /tmp but can be customized.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is needed for all supported branches.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Due to bug 1193730 profiles for Firefox cannot be created at the given location. It's not strictly blocking us, so lets see how this will be handled. For now I would say lets get the CLI option working for the installation of the build. Everything else can be a follow-up.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: github_pull_request.txt

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8654073 [details] [review]
github_pull_request.txt

Looks good!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

PR got merged to master as:
https://github.com/mozilla/firefox-ui-tests/commit/7376b5962a337914f3db085cb8c388a7b63b4626

I will backport the patch to all other branches if master is going to stay stable when using mozharness.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Tested with mozharness script and it works fine. So I pushed those changes to all other branches:

https://github.com/mozilla/firefox-ui-tests/commit/25229c65b69efce4717d73e5a51f2025bac34553 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/4cfff87d2044fd1046de39bc00e34ff92e747cf6 (beta)
https://github.com/mozilla/firefox-ui-tests/commit/4f7188bd0b84a5f3374ce3df722b3755e02152c5 (release)
https://github.com/mozilla/firefox-ui-tests/commit/6b0c0d2619d2c83055e75af383929a67fdc3e151 (esr38)